mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Andrey Bugaevskiy <bugaevskiy@yandex-team.ru>, musl@lists.openwall.com
Subject: Re: [musl] errno and swapcontext in a multithreaded setup
Date: Thu, 8 Apr 2021 13:17:35 -0400	[thread overview]
Message-ID: <20210408171734.GA2546@brightrain.aerifal.cx> (raw)
In-Reply-To: <87wntc1zee.fsf@oldenburg.str.redhat.com>

On Thu, Apr 08, 2021 at 07:04:09PM +0200, Florian Weimer wrote:
> * Andrey Bugaevskiy:
> 
> > I'm using makecontext/swapcontext to migrate contexts between threads
> > and this sometimes leads to getting incorrect errno values.
> >
> > Investigating further I've noticed that __errno_location
> > is marked __attribute__((const)).
> > This causes optimizers to assume that errno address never changes
> > in the scope of the function which is not the case in my scenario.
> 
> The optimizers make the same assumption for actual thread-local
> variables, not just __errno_location.  Migrating contexts between
> threads results in undefined behavior.

Indeed, this is not functionality that has ever been defined on any
implementation I'm aware of. There are a lot of other things that
could go wrong. Even if you don't explicitly use TLS, if your code is
built with stack protector it may access the canary value from TLS,
and the value may be individual to each thread (musl doesn't currently
do this, but could in the future as further hardening).

Rich

  reply	other threads:[~2021-04-08 17:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 16:10 Andrey Bugaevskiy
2021-04-08 17:04 ` Florian Weimer
2021-04-08 17:17   ` Rich Felker [this message]
2021-04-08 17:46   ` Andrey Bugaevskiy
2021-04-08 18:55     ` Rich Felker
2021-04-09 12:11       ` Andrey Bugaevskiy
2021-04-09 12:15         ` 'Rich Felker'
2021-04-08 17:40 ` Ariadne Conill
2021-04-08 17:49   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408171734.GA2546@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=bugaevskiy@yandex-team.ru \
    --cc=fweimer@redhat.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).