From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26885 invoked from network); 12 Apr 2021 14:17:46 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2021 14:17:46 -0000 Received: (qmail 26211 invoked by uid 550); 12 Apr 2021 14:17:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 26191 invoked from network); 12 Apr 2021 14:17:42 -0000 Date: Mon, 12 Apr 2021 10:17:30 -0400 From: Rich Felker To: Dominique Martinet Cc: musl@lists.openwall.com Message-ID: <20210412141729.GL2546@brightrain.aerifal.cx> References: <20210326054456.899700-1-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210326054456.899700-1-dominique.martinet@atmark-techno.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [PATCH] nftw: implement FTW_ACTIONRETVAL On Fri, Mar 26, 2021 at 02:44:56PM +0900, Dominique Martinet wrote: > nftw is sometimes used with e.g. FTW_SKIP_SUBTREE on linux which > requires special handling. > > A similar patch was sent in 2018[1] and general feedbacks for nftw > seemed positive, but the original work's license was not clear so this > implementation was made without using it, looking at the linux man page > and comparing with glibc's behaviour through test programs. > > [1] https://www.openwall.com/lists/musl/2018/12/16/1 Feedback for that submission as a whole was negative because it was just "throw in everything I found that systemd wanted", which is a policy discussion that's already been had and the answer is no. However that's not a judgement on any individual feature like FTW_ACTIONRETVAL, which could meet criteria for inclusion. I haven't gotten a good chance to look at this yet, but if you haven't already, could you post some supporting reasons for this (like widespread usage by applications that you've found)? That would help determine if it's appropriate. Rich