From: Rich Felker <dalias@libc.org>
To: "Érico Nogueira" <ericonr@disroot.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH 2/2] include <stdc-predef.h> in <features.h>
Date: Fri, 16 Apr 2021 10:26:58 -0400 [thread overview]
Message-ID: <20210416142658.GO2546@brightrain.aerifal.cx> (raw)
In-Reply-To: <20210416003521.2147-2-ericonr@disroot.org>
On Thu, Apr 15, 2021 at 09:35:21PM -0300, Érico Nogueira wrote:
> GCC source code does contain a function to pre-include the
> <stdc-predef.h> header for glibc targets, but even so glibc still
> includes it in their own <features.h> header. furthermore, even if GCC
> implemented this for musl targets, it is still necessary for other
> compilers or previous versions of GCC.
> ---
> include/features.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/features.h b/include/features.h
> index 85cfb72a..f3d53cbe 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -1,6 +1,8 @@
> #ifndef _FEATURES_H
> #define _FEATURES_H
>
> +#include <stdc-predef.h>
> +
> #if defined(_ALL_SOURCE) && !defined(_GNU_SOURCE)
> #define _GNU_SOURCE 1
> #endif
> --
> 2.31.1
I've hesitated to do this because features.h is not consistently
included from all standard headers (only if it's needed), and the
result would be inconsistent exposure of these macros. (Also
inconsistent if they're checked before any standard headers are
included, which is unfixable.) I think it makes more sense to just add
"-include stdc-predef.h" to the compiler specfile or equivalent if it
doesn't auto-include it, so that you get behavior that actually
matches the spec.
Rich
next prev parent reply other threads:[~2021-04-16 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 0:35 [musl] [PATCH 1/2] define __STDC_UTF_{16,32}__ macros Érico Nogueira
2021-04-16 0:35 ` [musl] [PATCH 2/2] include <stdc-predef.h> in <features.h> Érico Nogueira
2021-04-16 14:26 ` Rich Felker [this message]
2021-04-16 17:57 ` Érico Nogueira
2021-04-16 18:51 ` Rich Felker
2021-04-16 22:12 ` James Y Knight
2021-04-17 0:00 ` Rich Felker
2021-04-17 1:56 ` James Y Knight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416142658.GO2546@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).