From: Szabolcs Nagy <nsz@port70.net>
To: Matus Kysel <mkysel@tachyum.com>
Cc: musl@lists.openwall.com
Subject: [musl] Re: libc-test issue with sem_close
Date: Tue, 27 Apr 2021 21:55:50 +0200 [thread overview]
Message-ID: <20210427195550.GK2799122@port70.net> (raw)
In-Reply-To: <611bff39248143248ce9edd6762fb804@tachyum.com>
* Matus Kysel <mkysel@tachyum.com> [2021-04-26 09:49:35 +0000]:
> Hi Szabolcs,
>
> I am using your library as part of my validation suite and recently I have updated it to latest master, but the sem_close test is not buildable for me as it is missing fcntl.h header. I have attached possible fix, because I did not found how to contribute to you repo.
ccing musl, libc-test is mostly discussed there.
posix says
"Inclusion of the <semaphore.h> header may make visible symbols defined in the <fcntl.h> and <time.h> headers."
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/semaphore.h.html
which sounds optional, not guaranteed visibility of O_ open flags in
semaphore.h, but sem_open is expected to be usable with only semaphore.h
https://pubs.opengroup.org/onlinepubs/9699919799/functions/sem_open.html
i'm not sure what is the strict standard requirement here, without
clarification i consider it a libc header issue if an api is not usable
with just the header where it is declared.
next parent reply other threads:[~2021-04-27 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <611bff39248143248ce9edd6762fb804@tachyum.com>
2021-04-27 19:55 ` Szabolcs Nagy [this message]
2021-04-27 20:33 ` Érico Nogueira
2021-04-27 20:49 ` Érico Nogueira
2021-04-27 20:55 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210427195550.GK2799122@port70.net \
--to=nsz@port70.net \
--cc=mkysel@tachyum.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).