mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] remove return with expression in void function
Date: Tue, 27 Apr 2021 21:57:01 -0400	[thread overview]
Message-ID: <20210428015701.GV2546@brightrain.aerifal.cx> (raw)
In-Reply-To: <20210427225955.19592-1-mforney@mforney.org>

On Tue, Apr 27, 2021 at 03:59:55PM -0700, Michael Forney wrote:
> ISO C says
> 
> > A return statement with an expression shall not appear in a
> > function whose return type is void
> ---
>  src/malloc/free.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/malloc/free.c b/src/malloc/free.c
> index f17a952c..3944f7b2 100644
> --- a/src/malloc/free.c
> +++ b/src/malloc/free.c
> @@ -2,5 +2,5 @@
>  
>  void free(void *p)
>  {
> -	return __libc_free(p);
> +	__libc_free(p);
>  }
> -- 
> 2.31.1

Thanks, applying!

Rich

      reply	other threads:[~2021-04-28  1:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 22:59 Michael Forney
2021-04-28  1:57 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428015701.GV2546@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).