From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: [musl] [PATCH] math: avoid internal overflow in expm1l.c
Date: Mon, 10 May 2021 22:53:03 +0200 [thread overview]
Message-ID: <20210510205303.GO2799122@port70.net> (raw)
the ld80 expm1l implementation in c tries to compute
2^k q + 2^k - 1
but 2^k can overflow (when k==16384) while q is small and negative.
then the result should be finite, but the code gives nan. to avoid the
overflow use
2 (2^(k-1) q + 2^(k-1) - 0.5).
note: this implementation is not used on x86 currently.
---
src/math/expm1l.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/math/expm1l.c b/src/math/expm1l.c
index d1715078..79795dc0 100644
--- a/src/math/expm1l.c
+++ b/src/math/expm1l.c
@@ -109,9 +109,9 @@ long double expm1l(long double x)
/* exp(x) = exp(k ln 2) exp(remainder ln 2) = 2^k exp(remainder ln 2).
We have qx = exp(remainder ln 2) - 1, so
- exp(x) - 1 = 2^k (qx + 1) - 1 = 2^k qx + 2^k - 1. */
- px = scalbnl(1.0, k);
- x = px * qx + (px - 1.0);
+ exp(x) - 1 = 2^k (qx + 1) - 1 = 2 (2^(k-1) qx + 2^(k-1) - 0.5). */
+ px = scalbnl(1.0, k-1);
+ x = 2*(px * qx + (px - 0.5));
return x;
}
#elif LDBL_MANT_DIG == 113 && LDBL_MAX_EXP == 16384
--
2.29.2
reply other threads:[~2021-05-10 20:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510205303.GO2799122@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).