mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [musl] Re: nftw: FTW_CHDIR defined but not implemented
Date: Thu, 23 Sep 2021 20:15:54 -0400	[thread overview]
Message-ID: <20210924001554.GX13220@brightrain.aerifal.cx> (raw)
In-Reply-To: <3OO2PBDGFF260.2CC0KDWJRFXU5@8pit.net>

On Sat, Sep 04, 2021 at 05:04:21PM +0200, Sören Tempel wrote:
> Ariadne Conill <ariadne@dereferenced.org> wrote:
> > Hi,
> 
> Hello,
> 
> > I can write a patch for it if we don't have one already.  It would be nice 
> > to get this one fixed in the Alpine 3.15 release cycle.
> 
> No, we don't have one yet. Feel free to write one! :)

If it's simple enough I don't mind reviewing it, but I'd really like
to rewrite this whole function to use an explicit stack. As it is now,
it blows away the stack badly on deep trees unless you ensure it's
only called from threads with rather large stacks. There's no good
reason for such a limitation, especially on a system with a PATH_MAX.

Having just written dir tree walking code for another project, I've
got this on my mind, and might try doing it sometime soon.

Rich

      reply	other threads:[~2021-09-24  0:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 16:02 [musl] " Sören Tempel
2021-09-03 14:50 ` [musl] " Sören Tempel
2021-09-03 18:26   ` Ariadne Conill
2021-09-04 15:04     ` Sören Tempel
2021-09-24  0:15       ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924001554.GX13220@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).