mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Terefang Verigorn <terefang@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] possible buffer overflow in crypt() -- musl-1.2.2
Date: Thu, 4 Nov 2021 12:13:14 -0400	[thread overview]
Message-ID: <20211104161313.GG7074@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAFvOk+oPyMJdhqavobK3DK5zhgY6puZkziDtUF4yqXkMwPQXZw@mail.gmail.com>

On Thu, Nov 04, 2021 at 03:53:12PM +0100, Terefang Verigorn wrote:
> hello
> 
> crypt.h declares
> ---
> struct crypt_data {
>    int initialized;
>    char __buf[256];
> };
> ---
> 
> but crypt.c uses
> ---
> static char buf[128];
> return __crypt_r(key, salt, (struct crypt_data *)buf);
> ---
> 
> the buf[128] should be rather buf[sizeof(crypt_data)]

Do you have reason to believe it needs more than 128 bytes? The
crypt_data struct has no inherent relation to what's needed; it was
just needed to provide a public ABI for the caller to have enough
(more than enough, for future-proofing or whatever) storage for the
result.

Rich

  parent reply	other threads:[~2021-11-04 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 14:53 Terefang Verigorn
2021-11-04 15:13 ` [musl] " Terefang Verigorn
2021-11-04 16:13 ` Rich Felker [this message]
2021-11-04 16:32 ` [musl] " Charlotte Delenk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104161313.GG7074@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    --cc=terefang@gmail.com \
    --subject='Re: [musl] possible buffer overflow in crypt() -- musl-1.2.2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).