mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Markus Wichmann <>
Subject: Re: [musl] ASM-to-C conversion for i386
Date: Mon, 27 Dec 2021 19:04:37 +0100	[thread overview]
Message-ID: <20211227180437.GE1949@voyager> (raw)
In-Reply-To: <>

On Mon, Dec 27, 2021 at 11:30:56AM -0500, Rich Felker wrote:
> One thought, and I'm not sure if this is a good idea or a bad one but
> worth discussing:
> Using your acos.c as an example, where you have the comment:
> 	atan2(fabs(sqrt((1-x)*(1+x))), x)

That comment was copied from acos.s. In general, I have tried to
preserve comments. Except in fenv.s, where each time __hwcap was tested,
the same comment was prefixed, and its point should be coming across ten
times more easily by just creating a symbolic constant.

> The actual code could be written as:
> 	return (double)x87_fpatan(x, x87_fabs(x87_fsqrt((1-x)*(1+x))));
> with the appropriate "x87.h" defining each of these with the
> appropriate asm & constraints. This kinda makes the individual
> functions self-documenting and non-error-prone (repetition of
> error-prone constraints, especially the hidden requirement that, in
> "=t"(x), x have type long double).

That's probably an even better idea than what I am currently doing:
Moving the "core" functions into a new header file (as static inline
functions), and using these in the function implementations. I could not
get all the duplication out; in some cases the duplication is only
conceptual (hypot() and hypotf() have the same idea, but it needs to be
implemented differently due to the different precisions/representations).

I think I can combine both approaches, because what I'm doing appears to
have the effect of moving the __asm__ statements entirely out of the C
files into the new header file. And it appears that we are only using a
couple of instructions, anyway.

Downside is that implementing

static inline long double x87_fabs(long double x) {
    __asm__("fabs" : "+t"(x));
    return x;

now actually carries the connotation that the result is of
double-extended precision and needs rounding before being returned.
Unlike the current version which does not do that. However, to my
knowledge that will not actually be wrong, only slower, so a solution
that preserves the current connotations for these few instructions can
probably be considered a micro-optimization.


  reply	other threads:[~2021-12-27 18:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 20:42 Markus Wichmann
2021-12-26 21:20 ` Markus Wichmann
2021-12-27 13:08 ` Markus Wichmann
2021-12-27 15:00 ` Rich Felker
2021-12-27 16:27   ` Markus Wichmann
2021-12-27 16:30   ` Rich Felker
2021-12-27 18:04     ` Markus Wichmann [this message]
2021-12-27 18:41       ` Rich Felker
2021-12-28  8:42         ` Markus Wichmann
2021-12-29 10:02   ` Markus Wichmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227180437.GE1949@voyager \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).