mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <>
To: Nihal Jere <>
Subject: Re: [musl] Dynamic linker segfault
Date: Tue, 4 Jan 2022 16:42:12 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <YdS7rrVPInqjpFTu@debussy>

On Tue, Jan 04, 2022 at 03:27:10PM -0600, Nihal Jere wrote:
> Hi,
> ldd from master segfaults when run on [1] and [2]. It happens on
> this[3] line. It seems to happen due to the intersection of a few
> factors:
> 1. The segment at the lowest address is read-only.
> 2. A segment on the the same page is read/write.
> 3. The read/write segment has memsz > filesz.

This is a malformed program file not compatible with the machine page
size (4k). Arguably it should be detected as p_align < PAGESIZE -- in
a sense, p_align for LOAD segments is the maximum supported page size
for the program file, and machines not capable of providing a page
size that small can't map/run it. In theory the loader could allow
this if all the differences between segments satisfy the right
congruences and have matching permissions where the maps would
overlap, but I'm not sure that's useful.

What tooling generated this file?

> This results in a segfault, as it tries to memset[3] on the mmap
> created here[4], which has the same protection as the segment at
> the lowest address (i.e. read-only).
> As far as I can see, the options are to either:
> a. detect this and throw an error.
> b. 'or' together the protection flags of all the segments on the page.
> I'm not sure what the right behavior is, but I don't think segfaulting
> is right, and I'm sure there are people here what's correct.

There is a huge range of "syntactically valid but not correct" things
ELF can represent, and musl has never attempted to catch or diagnose
all such errors. It might be desirable to increase the level to which
we catch common ones, but proceeding on this probably depends on how
this file came to be. If it was made by intentionally passing bad
options to the linker or with a custom linker that's not honoring the
semantic requirements for an executable for the platform, I think
there's a lot of lower-hanging fruit if we wanted to start diagnosing
this sort of thing.

Of course diagnosing p_align < PAGESIZE as an error might make sense
in general.


  reply	other threads:[~2022-01-04 21:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 21:27 Nihal Jere
2022-01-04 21:42 ` Rich Felker [this message]
2022-01-05  8:56   ` Florian Weimer
2022-01-05 13:49     ` Rich Felker
2022-01-05 14:00       ` Florian Weimer
2022-01-05 15:00         ` Rich Felker
2022-01-07 13:58           ` Florian Weimer
2022-01-07 17:35             ` Rich Felker
2022-01-10 13:30               ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).