From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 25923 invoked from network); 7 Jan 2022 18:32:20 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 7 Jan 2022 18:32:20 -0000 Received: (qmail 24369 invoked by uid 550); 7 Jan 2022 18:32:15 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 24322 invoked from network); 7 Jan 2022 18:32:15 -0000 Date: Fri, 7 Jan 2022 13:32:02 -0500 From: Rich Felker To: Wesley Wiser Cc: "musl@lists.openwall.com" Message-ID: <20220107183202.GL7074@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] RE: [PATCH] fix: Use $srcdir in configure test for add-cfi script On Fri, Jan 07, 2022 at 06:02:57PM +0000, Wesley Wiser wrote: > On Thu, Oct 21, 2021 at 04:09:30PM -0400, Wesley Wiser wrote: > > I noticed while building musl with musl-cross-make[1] that adding --enable-debug to the MUSL_CONFIG variable did not enable CFI directives even though I was compiling for a supported platform (x86_64): > > I believe the issue is that configure tests for "tools/add-cfi.$ARCH.awk" instead of "$srcdir/tools/add-cfi.$ARCH.awk". Changing configure as described resolves this and I've confirmed the debugging information is present in resulting binary. > > Below is a patch for this change. > > Hello all, > > Just wanted to follow up and see if there was any feedback on this > patch. I can confirm it does resolve the described issue. Thanks for the ping. It looks good; I'll merge it now. Rich