From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.1 required=5.0 tests=BULK_RE_SUSP_NTLD,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,
	PDS_OTHER_BAD_TLD,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 16979 invoked from network); 2 Mar 2022 22:08:16 -0000
Received: from mother.openwall.net (195.42.179.200)
  by inbox.vuxu.org with ESMTPUTF8; 2 Mar 2022 22:08:16 -0000
Received: (qmail 5500 invoked by uid 550); 2 Mar 2022 22:08:13 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 5468 invoked from network); 2 Mar 2022 22:08:12 -0000
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=fifth.space; h=date:from
	:to:subject:message-id:in-reply-to:references:mime-version
	:content-type:content-transfer-encoding; s=20190812; bh=BwjhOOSi
	kKir5ycz8Dt3tM5ct9o=; b=EXnr9rESc1AcZzpl9CwtBosSc69UfaFpSAqyfk0f
	/uW3rVrPrT06meYCQKahkg5OzNFPcBBLNSzgcI44tZJdKfgdSUEiAeIFepvuktth
	oTHG7HN2213rnjesO6gsU37uDeyxbl2WU1u71OF7lHjOPZLhjk0VmIamHNnIDWYD
	pC94wVRuHS5uQaz0ofDQCmjNykgnqOqDzs427ONLED4Tnd9KBsdVbpSvHXPEyqv0
	iZKcBdB6VXjnv0JbvK2JGyzoJFJ0mCFg8UizaZfnP3gZYLsxcp5gZX3h03C2AWFo
	8cJuFXouTLmWHy3eQF3Jf73CkZ176hUA3g6FOLgD6ndFfA==
DomainKey-Signature: a=rsa-sha1; c=nofws; d=fifth.space; h=date:from:to
	:subject:message-id:in-reply-to:references:mime-version
	:content-type:content-transfer-encoding; q=dns; s=20190812; b=aj
	quUv3FgT9S5VBHqlISiYohMIdw0uWq2Q0yErVxuaJmUbMNyvipcxoucmp39SfrxC
	o/aL5x3V6oJAGEIz0Lwq7QM0YMjZ0OEuNLqZcHn0EIrL749hVmw8UQp5+FLpVsen
	2Lp1iFYPfaz/wr1Y2il34qB/kaEbq9Wa5ZCWj4KPvDy1NQmTMykgzhZTGyV2ODrO
	nSFus+OmvzoftgAlsbdwzKnPZ5IDE0rUrwDxW1TrEOj4Jw8NB9eiNpu9redqhsCN
	P3tlBhXmWL/PmBlvy8FZaGcupyBLAd/nQFzVBhBPwEugEOQMBoaOz6dlTet3hLP5
	jVrNUstOyuj8sTikTD+A==
Date: Wed, 2 Mar 2022 23:07:56 +0100
From: Quentin Rameau <quinq@fifth.space>
To: musl@lists.openwall.com
Message-ID: <20220302230756.3ecc46eb.quinq@fifth.space>
In-Reply-To: <cb4926e9-243-1dba-9110-2b62bb7b406a@dereferenced.org>
References: <20220302201654.98472-1-alice@ayaya.dev>
	<cb4926e9-243-1dba-9110-2b62bb7b406a@dereferenced.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [musl] [PATCH] abort transaction lookup if NULL is passed as
 msgid1

Hi,

> Hi,
> 
> On Wed, 2 Mar 2022, psykose wrote:
> 
> > When investigating a crash in Transmission running under musl's gettext
> > implementation, we observed that GNU libintl returns NULL when NULL is
> > passed as the msgid1.  Accordingly, make the musl gettext behavior match
> > GNU libintl.
> >
> > Reviewed-by: Ariadne Conill <ariadne@dereferenced.org>
> 
> I can confirm I did in fact review this.
> 
> Acked-by: Ariadne Conill <ariadne@dereferenced.org>

I pledge I've seen Ariadne confirming reviewing this.