mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] nice: return EPERM instead of EACCES
Date: Tue, 8 Mar 2022 17:16:08 -0500	[thread overview]
Message-ID: <20220308221607.GR7074@brightrain.aerifal.cx> (raw)
In-Reply-To: <af21ec84-56a1-c25a-3672-06a48d3e9916@bell-sw.com>

On Tue, Aug 03, 2021 at 12:18:15PM +0300, Alexey Kodanev wrote:
> On 29.06.2021 23:10, Rich Felker wrote:
> > On Tue, Jun 29, 2021 at 06:45:42PM +0300, Alexey Kodanev wrote:
> >> On 29.06.2021 17:48, Rich Felker wrote:
> >>> Is there actually an issue here? setpriority is specified to fail with
> >>> EACCES already for this case; EPERM is only specified for targeting
> >>> other processes you don't have permission to target. Is Linux getting
> >>> this wrong for setpriority?
> >>
> >> No, it's fine for setpriority(), it just seems wrong for nice()
> >> to return EACCES in this case.
> >>
> >> LTP/nice04 test (setting nice(-10)) is failing with musl and POSIX
> >> indeed says that the errno should be EPERM, for nice().
> > 
> > Oh, sorry, I read it backwards and was thinking it was replacing EPERM
> > with EACCES. Indeed nice is supposed to return EPERM where setpriority
> > would return EACCES so I think this patch is correct.
> > 
> 
> Hi Rich,
> 
> I wonder what is the status of this patch, didn't find it in git... is
> there any issue with it?

Sorry I overlooked this for so long! I'm merging it now.

Rich

      reply	other threads:[~2022-03-08 22:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:31 Alexey Kodanev
2021-06-29 14:48 ` Rich Felker
2021-06-29 15:45   ` Alexey Kodanev
2021-06-29 20:10     ` Rich Felker
2021-08-03  9:18       ` Alexey Kodanev
2022-03-08 22:16         ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308221607.GR7074@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=aleksei.kodanev@bell-sw.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).