From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 25601 invoked from network); 5 Apr 2022 04:44:16 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 5 Apr 2022 04:44:16 -0000 Received: (qmail 9791 invoked by uid 550); 5 Apr 2022 04:44:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9750 invoked from network); 5 Apr 2022 04:44:13 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1649133841; bh=DhF05u5kxCu5XJbUqfg+tu9lCZ7DkZYKW+RaixBlU1w=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=dbEi/TxNgUzXcxs6P+MMKPaSIipkgw657ZB/EygQIu/fQ25o9v93JFR3cr7sHdXR2 WXDMWASAPWu07/UtA/xsE6wVWflKe4WNhHtGgFdX5x2FqZy6vk3QAndRd0CJWj9Dj5 aSjFfyzBd4CbFw2QHyMmaCAc2eAB9L6zzF13xw1Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Date: Tue, 5 Apr 2022 06:43:59 +0200 From: Markus Wichmann To: musl@lists.openwall.com Cc: Colin Cross Message-ID: <20220405044359.GA8499@voyager> References: <20220405031859.17673-1-ccross@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405031859.17673-1-ccross@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Provags-ID: V03:K1:gh7gam99r9tYwbq/siGZnZ5yQemK46muaPBv3FSxKMdsXjQPCTw ll2+tJqEwc+Bmx3ov7R0lc6HY1ByexZmq+wc+aN0GP+/uOBn/w1c+zV7HucnupgjUc53RQv udCXoS+MtAYUbzyQ7WY4KfKkE0Z4bkkviDin8WY+NARG80I9J8I635GbpnCzeqS78+2/h0G 5dC9v7X22KGoINVuYe9sQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Dc21U1uFZmY=:AjUF7f5XaZ3T1E2ZZJvMpK g+8lxjFPhydHuf9vgyR42xB8PUAvZOYITBQSqlzwsjGagwaqchccL5U+IdSo96zCbfYHPOWxC GiuAYBsYroZpNS6qzQ8a0soskXYNQhFd2Q53K87j2lxaKS/xGLrOlxm7RhbyUf74tGNu1poJ1 H3tvrW+jEiNWuVzF3tV55iBS5oypECQn3ma1R4mv0FoaSQ9K3Qc+ESM8wsX9N0ayTN3ifxN8t LvUasMhHho1sNC2VMs1m8VuTcUp7QN8gMB1nefO08ukWF08iCWEAd447ftOPMjri7LV/dH4FY 7SkyTh68LvnvaPzJXqNrIBVc1XMl/a+4nNfQQf3TWSQ7kR1/XtJPTLRKYwHxijPLT+cyJORcu r/IECdMRjsjKOrptKh/+b06bAuiKgkNETbdsgIRe2RTMBlt+3v6FzKI0otiLsbdQxtYnOJWlG hEL0+dfjjvE8Y90AndjFPd34znYWdzvy/aj3gKkjiXtJu0xFZBiewpRBXZlgYSt4rLciwl5hB xo7ZVa+gUAr1I6n7T0o7eFDIcBgcGcqZ/SoNiUiPT3FVbBINop+OjpELfbNqmWI616bzecHE1 8cSwHn2SXxuNQMWjQJlonrUk3kpimbBibaxbHr6X8lP44HxFMuMM7jqoFtiaLHvtOfvnkuEwa RemgxsFnl0X8spSZ4z6HeF74HRJBEcO9+oa6IIICqMrhKj40c/DtuX9h8vvBBXoSJHVI1jofX 6HgApp8j3mnfpKU3ZCbYQusdCUWE8J5PXv4zZmmmSF6N6ba6hBQaM/WHPjURzxzwojNaX7sr+ Eb5/ligDT1jc2rz242+fQyMNq07tJDc+PjvGYpwvMS/Kz8vJhdiAXvaNYKFT5RQkv/kDAHqDb aWSeNL3xFk81N+NoiD98I/aFI7L7iKExyEerSecRk3nRyUCuKH7OsRMfeqFq5WQ+1poKBtns/ MPEdT5DYU4mwXM1jR7A6wDkNxkYuIt3AxAKCwK5RxuZ90cA3YVPhtPNf+7x4nI/08YhhLISsa VGmBHrUqljOAKsf2B8DXZaclpM5BnEqKsoPw3PrS3ujZdJkbXbcYQY251zPsAr5Z9NfQlCxoG D8PuF8qMlPm8Fo= Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] [PATCH] dl_iterate_phdr: return empty string for the name of the main program On Mon, Apr 04, 2022 at 08:18:59PM -0700, Colin Cross wrote: > diff --git a/ldso/dynlink.c b/ldso/dynlink.c > index fd0d38e9..d2e22a0b 100644 > --- a/ldso/dynlink.c > +++ b/ldso/dynlink.c > @@ -2323,12 +2323,15 @@ no_redir: > > int dl_iterate_phdr(int(*callback)(struct dl_phdr_info *info, size_t si= ze, void *data), void *data) > { > + static const char* empty_string =3D ""; > struct dso *current; > struct dl_phdr_info info; > int ret =3D 0; > for(current =3D head; current;) { > info.dlpi_addr =3D (uintptr_t)current->base; > - info.dlpi_name =3D current->name; > + /* glibc uses an empty string for the main program */ > + info.dlpi_name =3D (current =3D=3D head) ? empty_string : > + current->name; > info.dlpi_phdr =3D current->phdr; > info.dlpi_phnum =3D current->phnum; > info.dlpi_adds =3D gencnt; > -- > 2.35.1.1094.g7c7d902a7c-goog > Any particular reason you chose to create an object for the empty string, instead of just using an empty string? I.e. why not just info.dlpi_name =3D current=3D=3Dhead? "" : current->name; Ciao, Markus