From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: [musl] Problem with strdupa in C++ code
Date: Tue, 12 Apr 2022 18:15:59 +0200 [thread overview]
Message-ID: <20220412161559.GC8499@voyager> (raw)
In-Reply-To: <YlTQgBwQEgukb3N3@ws>
Hi all,
so I tried to find some authority on this, but per the manpage,
strdupa() is a GNU extension. So I looked up the implementation in
glibc, which is near enough the only authority on whether this is
supposed to work in C++, and they do add the casts necessary to make it
work. Although they massively overcomplicate the matter with a statement
expression for God knows what reason.
So I guess we should add the cast, too. I see nothing obviously wrong
with the suggested replacement.
Ciao,
Markus
next prev parent reply other threads:[~2022-04-12 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 1:06 Wolf
2022-04-12 16:15 ` Markus Wichmann [this message]
2022-04-12 16:24 ` Joakim Sindholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412161559.GC8499@voyager \
--to=nullplan@gmx.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).