From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 375 invoked from network); 12 Apr 2022 16:16:17 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2022 16:16:17 -0000 Received: (qmail 9300 invoked by uid 550); 12 Apr 2022 16:16:13 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 9256 invoked from network); 12 Apr 2022 16:16:12 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1649780161; bh=u9h2/MBtl1nIEFQTue1+fOUarJGvbpxKNiExXrm9g7c=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=ann319LvTNHFRMd5sNhLdY/h6gPeY8n6B3RIqTlPpxSuivMHjeVSdN0FZkKRD6grn 0nlzaEndM2q9r2MRut/MC+cjyudyMOIeSOI9cmhYrUPK6k2WOWIxpNtHGK8SsLD224 hpXX8v1yqmUMVLrd3fKlZC6TC76g/h4WkEpB49Kk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Date: Tue, 12 Apr 2022 18:15:59 +0200 From: Markus Wichmann To: musl@lists.openwall.com Message-ID: <20220412161559.GC8499@voyager> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Provags-ID: V03:K1:WlDsRpD0avJH9CZeWbpab9ZUVnKzkVggWAXhLvXFOgUZTHfvtw+ MJb5NuAOKepiQqv/XnDErsb5Q3EvFiPrBjHEbr+Ff/RSybBUuwgETEYDfOsC/4TkhwIxx+f IjTPhJLLZdiHQA043EshVWAk7i23DFc+rcU1fYVprvM55HJi4Fi8OfksqrUcFOVlbJFBVb4 DAU27msB3yLni+5KA1vPQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:QeVe5Yb9Za8=:s0coDM+qS1bd+5bUK/kJ5g shdQD3SURxsf18bLfAbromIRfowKiuwSJaIJz9wNtTbibwHTUzaU1+QkHSF8RKWjz/l/nA37t bEKsDuyB3nKvyS+tNWAQP3OvEDf+3F7KBlL2A+BHDJYZQImlVkXmEuxtHHFzHkQ7suMpUrf0m csu3IT++Zfc+85Ia+Tb2dUoNsBZlU3cSnZx/xEDV8xEqPRdRaGP+I64UBic0FyjzMdYo/W5/3 Y42O0n4yA+zTF+F2bfr36ks2omNSeZPR9DFp8/gURWMYer/I8lKtzmE98rNmB1q7pa37dtTUr OxvHtwSfRUyijwEM5wBWS7IfLZpJwTDvp+7NV2TvYykck9ocwY/N55rKOnmOZACpG5V5PfqBj O7BPTMJmPDobWzWzxQZgD3gACRWQ+Jma1Znd9s2qdF8kjbhDgRnzLFyQJNbShfK5SixsUShpL U4Kv0gx06NumdormvdICM/97OBr80O4hTHX+TulMTD3Dpzip7JXPaWUqJUJ9SL2wTxyFPLp6V b5e9wpjige9dNBwB56WpwDlaeLknT4PgOXi0Al76uOlWqMZWCKYuHCYlqWPXwZ7yOWpIOvOBs UUGlAzNZU7oyE7zRO4GPQNpN7cGYZKWXypovyofsrn7fMa3MYyZ/ZaoBe5Jy7P0AkgrZjX2rc rPgXAWIezC3Zs4P7pqg5YqqvaTz5njNo/IfXZ1BSaiJRDxpXTrtPxhFZzl/nHApmG1jWL8Q9h Sh7lJKPyZF8pr3O1jnTlRzNcaAbJAtPkn5bM3zWcpAUCOmyQD7Sw3vaUe9TaIilDnMSNUpqPR CPmnLyQf/L8uNjFsM7lzms6JV8YrKQnvmOVw2JoXulCX9Id9pAzeXihWjUGgBLBJod1ne+PHQ HhlQ675bKwb7GSz1ZkWEph1TkoX6mP+jvhP2WlsBZNeAkU/RY0k9d9BkFmQo8XJzapq5pMWos 9jm7GAuQOk1EXshDCrMTG0yS3B47Qqp/wLer17A1mTDt+Mi1HQ538+I8Neh34QUyLaSz78qY7 bicLJ5ZMpLsKt/BVra1kvngXXR1reyXBeR/s1RNSPNMc6KA1X8zDz71X6iefDGVTG1rhOTl3o pOZzGHidYHefAY= Subject: Re: [musl] Problem with strdupa in C++ code Hi all, so I tried to find some authority on this, but per the manpage, strdupa() is a GNU extension. So I looked up the implementation in glibc, which is near enough the only authority on whether this is supposed to work in C++, and they do add the casts necessary to make it work. Although they massively overcomplicate the matter with a statement expression for God knows what reason. So I guess we should add the cast, too. I see nothing obviously wrong with the suggested replacement. Ciao, Markus