From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
	RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 1669 invoked from network); 12 Apr 2022 16:24:53 -0000
Received: from mother.openwall.net (195.42.179.200)
  by inbox.vuxu.org with ESMTPUTF8; 12 Apr 2022 16:24:53 -0000
Received: (qmail 14266 invoked by uid 550); 12 Apr 2022 16:24:48 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 14234 invoked from network); 12 Apr 2022 16:24:47 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zhasha.com;
	s=wirbelwind; t=1649780676;
	bh=u6X9/HcEQHjrMx8r4bsaPZWVADp3LzToo0jGXz3rio8=;
	h=Date:From:To:Subject:In-Reply-To:References;
	b=PCA5/KO06cdw4lP7GC+zNHMjYWl4/4PBD2DjwKfeTjPwK/LbFJDA9vw/X24jUh4yE
	 OfvfwkMS/j6vxFkG0Si+DmTOsB4F44Plly9GHHVvS0nh3wd2pkYCKyYFWr2iHLurgn
	 rP8xnp3Is31ZiGWmA/t+W1GOI1LykyvqUawwT4AI=
Date: Tue, 12 Apr 2022 18:24:36 +0200
From: Joakim Sindholt <opensource@zhasha.com>
To: musl@lists.openwall.com
Message-Id: <20220412182436.519e76e5598d272e7a1afada@zhasha.com>
In-Reply-To: <20220412161559.GC8499@voyager>
References: <YlTQgBwQEgukb3N3@ws>
	<20220412161559.GC8499@voyager>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [musl] Problem with strdupa in C++ code

On Tue, 12 Apr 2022 18:15:59 +0200, Markus Wichmann <nullplan@gmx.net> wrote:
> Although they massively overcomplicate the matter with a statement
> expression for God knows what reason.

To avoid referencing the argument twice, so you can strdupa(s++).