mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Gary E. Miller" <gem@rellim.com>
To: musl@lists.openwall.com
Subject: Re: [musl] *strerror_r() bug in musl
Date: Wed, 13 Apr 2022 10:36:51 -0700	[thread overview]
Message-ID: <20220413103651.0087ca81@spidey.rellim.com> (raw)
In-Reply-To: <20220413140532.GT7074@brightrain.aerifal.cx>

[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]

Yo Rich!

On Wed, 13 Apr 2022 10:05:33 -0400
Rich Felker <dalias@libc.org> wrote:

> > > When _GNU_SOURCE is defined with glibc, then strerror_r() returns
> > > a char *.  
> > 
> > I have met this in multiple places the last decade. The usual way to
> > fix it is to also check for GNU libc in addition to _GNU_SOURCE.
> > 
> > #if defined (__GLIBC__) && defined (_GNU_SOURCE)
> > 	/* non-standard GLIBC exception */
> > #else
> > 	/* standard behavior for everything else */
> > #endif  
> 
> That, or probe for the signature with a configure-style check and use
> the result of that, as in
> 
> #ifdef HAVE_GNU_STRERROR_R
> // handle the GNU version
> #else
> // code written to the standard
> #endif

gpsd runs on a huge variety of hardware and software.  We used to have
rats nests of #ifdef's as suggested above.  But that only works when
your library code actually follows your documentation, and our dev
actually read and understood your documentation.

Since you doc fails to mention this "quirk", it is not possible to
forsee this issue before debugging the rare crash.

Now consider that gpsd supports well over 100 targets, back to POSIX
2001. glibc has a long history of changes around strerror_r(), and gpsd
has to support each one.  Then there are all the other libc.  That is a
lot of doc to check.  And a lot of #ifdeff version chacks.

OBTW: did I mention musl does not appear to have any #defines to
specify its current version?  Or even that it is musl?  Or did I
miss something else in the doc?

So you expect me to use the glibc #defines, because musl lacks them.

Not practical at scale.

gpsd prefers to check at configure time for all the known library calls
that are "quirky".  So, what I did was add, yet another, configure time
tesst


RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem@rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 851 bytes --]

  reply	other threads:[~2022-04-13 17:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 20:43 [musl] ✘strerror_r() " Gary E. Miller
2022-04-12 20:48 ` alice
2022-04-12 21:04   ` Gary E. Miller
2022-04-12 20:56 ` Alex Xu (Hello71)
2022-04-12 21:07   ` Gary E. Miller
2022-04-12 23:16     ` Wolf
2022-04-13  0:15       ` Gary E. Miller
2022-04-12 21:13   ` Gary E. Miller
2022-04-13  3:44 ` Rich Felker
2022-04-13 12:24 ` [musl] *strerror_r() " Natanael Copa
2022-04-13 14:05   ` Rich Felker
2022-04-13 17:36     ` Gary E. Miller [this message]
2022-04-13 20:38       ` Rich Felker
2022-04-13 21:16         ` Gary E. Miller
2022-04-13 22:27           ` Rich Felker
2022-04-13 22:43             ` Gary E. Miller
2022-04-13 22:58               ` Rich Felker
2022-04-13 23:07                 ` Gary E. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413103651.0087ca81@spidey.rellim.com \
    --to=gem@rellim.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).