From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 23672 invoked from network); 13 Apr 2022 12:24:50 -0000
Received: from mother.openwall.net (195.42.179.200)
  by inbox.vuxu.org with ESMTPUTF8; 13 Apr 2022 12:24:50 -0000
Received: (qmail 6058 invoked by uid 550); 13 Apr 2022 12:24:48 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 6024 invoked from network); 13 Apr 2022 12:24:47 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alpinelinux.org;
	s=smtp; t=1649852675;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=H3au9DFbqf4nsrrFgTJkZLOx1zrN60ayTrMgPaAyWxw=;
	b=K98raNlRzvcrkBvHdmqdzGh37TFGLVLVKKWJL34CZifvvhiJkQy1Z1a9ZODP2JterQLEPj
	B7H5P3Rs1RfwJsNNkuhal/daCUHIWrZWsFX8nGLu2oyOUdbo7RPZ6bT3FB7pLRUE4ZFitS
	7m3n3RI7gUhoQkCEjK6ssui90CVvF+M=
Date: Wed, 13 Apr 2022 14:24:32 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: "Gary E. Miller" <gem@rellim.com>
Cc: musl@lists.openwall.com
Message-ID: <20220413142432.311e20f5@ncopa-desktop.lan>
In-Reply-To: <20220412134355.59bd920e@spidey.rellim.com>
References: <20220412134355.59bd920e@spidey.rellim.com>
X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-alpine-linux-musl)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [musl] =?ISO-8859-1?B?KnN0cmVycm9yX3IoKQ==?= bug in musl

On Tue, 12 Apr 2022 13:43:55 -0700
"Gary E. Miller" <gem@rellim.com> wrote:

> Yo All!

Hi!

> 
> I'm new to the list.  I;ve been trying to report a musl bug on #musl since
> last Friday, but no one seems to live there.
> 
> musl (all versions) has a bug in strerror_r().
> 
> The musl reference manual says of _GNUSOURCE:
> 
>     _GNU_SOURCE (or _ALL_SOURCE)
> 
>     Adds everything above, plus interfaces modeled after GNU libc
>     extensions and interfaces for making use of Linux-specific features.
> 
> I take that to mean that when _GNU_SOURCE is used to compile code with musl
> that the results will behave as GNU libc (glinc).

Well, as other has mentioned. GNU libc has a non-compliant version of
strerror_r.

...
 
> When _GNU_SOURCE is defined with glibc, then strerror_r() returns a char *.

I have met this in multiple places the last decade. The usual way to
fix it is to also check for GNU libc in addition to _GNU_SOURCE.

#if defined (__GLIBC__) && defined (_GNU_SOURCE)
	/* non-standard GLIBC exception */
#else
	/* standard behavior for everything else */
#endif

-nc