From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8500 invoked from network); 15 May 2022 18:39:04 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 15 May 2022 18:39:04 -0000 Received: (qmail 1842 invoked by uid 550); 15 May 2022 18:38:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 1781 invoked from network); 15 May 2022 18:38:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652639923; x=1652726323; bh=Hg9MdBZm6n xKoDgIZ8aDJRPiZOLArFWujHma7sqOQ6c=; b=l+u8xBJFQx6z04/1fNBG+6osbs T7ng1G1wgdXwytzVoru3tEWt+/ZhzrJwH7GlzMUyGkcH6cS5tFbBdu5bB1seC2J1 ks+0OrE4DUhtbxX5T/BUP3/B8agBXwhHAOZNXu0SMyVgzanNF0zAwl/4SasO+dOt 0lx0Be1qZ18ymYXCDQtaHzH9UgALtKWJ37NiSZSMtLXdDw00CmpK+U+/hPPTRmNZ zwxn/dPd3Gr8YSzs7/Fod4u2XsAKxQKX2axxc7i+pQYpHUrztMkfVCGQmbZrs5cx 7keAvj+BhvytIkQW+jSw9XIy1Oi445lApAChq7Dbf7hDnf0g68AjIMrbO1hQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652639923; x= 1652726323; bh=Hg9MdBZm6nxKoDgIZ8aDJRPiZOLArFWujHma7sqOQ6c=; b=e eoo3Ig3rO0Jzfk8ccgZy6FRMSjfcIfrMLf8H7AcKazmWYNPfMz+BsIQjCzeKZ8r9 LhLSwAWuHStZc4rtg7f/Hpdu9blrg9u6GXQ/+2Bm+IQOwhu+vYJCYsqkomgTws4W uGGx2lvroYPZ7CCCNij5Z2oAPoJChwApcPCgGGQnxCGsf8lTjbhbypUAggMsSNRN 4tOvKiyh5sTdTL70/X0fFj67AIMQ17oMGnXue1+tF7qECjzye1SG6hdLtBPhusNr kWJ8IFI1yAiF3Du76WTWpoKDTqKlBV2JX+WKO7bRmML9Dlo/1rNxg7Ke1Kh2ysVk 1zxPdXdseUq7AKxeKAf7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheefgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehgtd erredttdejnecuhfhrohhmpeetlhihshhsrgcutfhoshhsuceohhhisegrlhihshhsrgdr ihhsqeenucggtffrrghtthgvrhhnpeegjeeigeejhffgffehueeludevhfeiffefudegvd egudfhudejheefhfeugfeghfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehqhihlihhsshesvghvvgdrqhihlhhishhsrdhnvght X-ME-Proxy: Date: Sun, 15 May 2022 18:38:40 +0000 From: Alyssa Ross To: Rich Felker Cc: musl@lists.openwall.com Message-ID: <20220515183840.csmpbq36vd3mmhan@eve> References: <20210915221155.3977763-1-hi@alyssa.is> <20210915221155.3977763-4-hi@alyssa.is> <20210920042140.GT13220@brightrain.aerifal.cx> <20220109031819.GO7074@brightrain.aerifal.cx> <878rvj1tut.fsf@alyssa.is> <20220113174037.GA7074@brightrain.aerifal.cx> <875yqn1n8g.fsf@alyssa.is> <20220512140835.GJ7074@brightrain.aerifal.cx> <20220512180235.5uadgd4iyxtdr37p@eve> <20220512181553.GK7074@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cewce4hxyluwuret" Content-Disposition: inline In-Reply-To: <20220512181553.GK7074@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH musl v2 3/3] mntent: fix parsing lines with optional fields --cewce4hxyluwuret Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rich, On Thu, May 12, 2022 at 02:15:53PM -0400, Rich Felker wrote: > Alright. It sounds like your patch is pretty much okay as-is except > for the added " || n[1]=3D=3Dlen" in the while condition and removing the > (now unreachable) return-zero condition at the end. If that sounds > right and it's okay with you I'm happy to commit your existing patch > with those changes then make any other improvements myself or review > further patches from you separately if you like. What do you think? Sounds good. Please go ahead and do it yourself =E2=80=94-it would take me= a fair bit of time to put my Musl development setup back together, so if you're happy to fix up and commit the patch there's no point in me doing that. --cewce4hxyluwuret Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmKBSK8ACgkQ+dvtSFmy ccC/tQ//VpnKLqG5NtnOFZq3VAoG7N3bqPteEvHEYZ1Oi5SW5r3jAcZRdoBglMbW MUY5rXM+mrFN0JBNgFYkLi2oa2fJbZhOaL/LuMDCfAEey3TxiH0jrpkXOfxnnyGH Sppo2pGCA6Rx6lymNn2VPN1QEZsR18C9gGi/AfjtSHPnw91trhV868HbjNDgBB2R EkDLLH9PQPkStFZv44jw8IfRAEzfk1RrbS9+r+FFNJTLUVypdOIHMlg6izGGTT/k ULG2ak9MZ1Gep/z03OyMmAi3+tv7by6S+a/YXNdt6J6lUr2JW246Ch/hroaTMgwA RfQlU/Te3z7vUdy3/3OBjH4LjBHazmMJkPkMmOudsX4b3dBcGaBBL+8Ak+EHRLcY uPqEZUZ03h4H6sj6EFvUaTdkWzz+zQ02e+iWEKvq9bzbNCXgCeJVNMKDeMctRmyI XqUJI1pBGPNee+CTziO4dxUxu4t7n9ZH8pYrbif5bqVn92hFr/51gEh9/A90Z0PW 04eUcpJmW0HHAiMnB2ioSMMAb4jzl77QbRvQLYpHlKq8SLRq8Fy8bZtguZH8Bg9K 35KtQaI75dFVP8wj+27bMwq4RZ6gY4C0iL7fTOLcjQJH75hKwu++jQPzOW3b231K d+sNouXptvKm3q3o5Usefl7EQfBY7OTe7h/3Nouzf1Y94tTmK7o= =6hxU -----END PGP SIGNATURE----- --cewce4hxyluwuret--