From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29452 invoked from network); 16 May 2022 10:07:47 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 16 May 2022 10:07:47 -0000 Received: (qmail 28541 invoked by uid 550); 16 May 2022 10:07:45 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 28509 invoked from network); 16 May 2022 10:07:44 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652695651; x=1652782051; bh=0d2Osn7UdJ 4ZNrYpdRnUC3cnJhITgR04u83agdSEn/Y=; b=b2LowUOLDTZ5nppMGRDhjvPaAM S7mgjnoJy9TmMbgZ2CZooyvpU4SfS0DT1bPM0QXsACIqxl6VIEQoCzQ+1ypUDemf AHPwFplvDoS5tKDkr55jQo/1Qm66lJYK4b/19EsNBLnZflGkmrr2AMiRe+qcSzq6 0nKwdDJm3VwaewM6+kPjxZkMEEbO4ce83TBiQWjXEgo7+HTw9OwAeTh97/O1VeQy gDWIMkcqiQdmPwl2luJX00dXpa+lzwXjAz6v48PIoa2uN7Om3E/uGqYGQIIfejLT /m9ieFaK5qXkuqa5f7rnq5wcymaSRCl4jtg3EcD98P7k4fkhp0N3Vm4+9I4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652695651; x= 1652782051; bh=0d2Osn7UdJ4ZNrYpdRnUC3cnJhITgR04u83agdSEn/Y=; b=X 5j+5qWSep8Y81AOdThnMd6KQ4FkWZNwYk1gl0Z5JN4/3ZXYW0sTK/lbDPrEmdWqM grKAfH3DdJlpGmr4oYWeUsD6+MdpmYC5K5XHASjxIgY3B28+gyquPJvhHgTCq6GI hEpeMOskWwfH/K9jOFtPGVw6pqZnfUHkRGxiCMI00B3nuVJC0zkyzKtXWucEnYki BzYEEHGUdf3L5BxQFyqcSLaT4KNwcZNRWuN9IjiSVNmWlacBmEJPNTirJwUcCFSY xs1VNWQyyk/2Iy4KlkrWmSsmxWfcqmr2ceeYGMP/77VBn7ryL03UsTwc07NBWON7 YDKQMkdLSjCxuY7v/Gkjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheehgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesghdtre ertddtvdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhi sheqnecuggftrfgrthhtvghrnhepvdegieefffekjefhvdfhtdffleetheejleeuhefhvd duieeuueegueejgfdttedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepqhihlhhishhssegvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Date: Mon, 16 May 2022 10:07:28 +0000 From: Alyssa Ross To: Rich Felker Cc: musl@lists.openwall.com Message-ID: <20220516100728.qnhevnlw7f3rufc6@eve> References: <20210915221155.3977763-1-hi@alyssa.is> <20210915221155.3977763-4-hi@alyssa.is> <20210920042140.GT13220@brightrain.aerifal.cx> <20220109031819.GO7074@brightrain.aerifal.cx> <878rvj1tut.fsf@alyssa.is> <20220113174037.GA7074@brightrain.aerifal.cx> <875yqn1n8g.fsf@alyssa.is> <20220512140835.GJ7074@brightrain.aerifal.cx> <20220515233154.GQ7074@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fnnxga2tdehpn7wt" Content-Disposition: inline In-Reply-To: <20220515233154.GQ7074@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH musl v2 3/3] mntent: fix parsing lines with optional fields --fnnxga2tdehpn7wt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 15, 2022 at 07:31:55PM -0400, Rich Felker wrote: > On Thu, May 12, 2022 at 10:08:37AM -0400, Rich Felker wrote: > > A few other changes I think should be made: > > > > [...] > > > > - The n[] array should be changed to size_t[] and the %n's to %zn's. > > This should actually be done as a separate change, as it's a fix for > > a bug overlooked when 05973dc3bbc1aca9b3c8347de6879ed72147ab3b made > > the buffer length potentially longer than INT_MAX. > > I'm going to reverse position on this: since getmntent_r only accepts > an int for the line length, the thread-unsafe getmntent should not be > able to process longer lines either. I'll instead just use the len you > already computed to treat lines longer than INT_MAX as invalid. Makes sense. --fnnxga2tdehpn7wt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmKCIl8ACgkQ+dvtSFmy ccD4Lg/+M9Ynspxjeb8e48bOndyLVAs+6Y2ANr8vkEwwt5XXhbMTM4PZgxOMEzzu oHn/3xeLjqxnmCAh53ji6SrOXHY2YiaTYn8UatMePHY0R9sxR/YuVI00WnyXeK2k 2EBEuhOn5U7CdrVwQ/FpS4pmQh21YRd7dnTjRdx6d9jJZAsBlM38v2bzIianDVYg XKDfUk6RDKr/Pe33fHzdPxShJVa16uWZDhFIsyPplGMdVAWrouo0lTEUujaBKCf2 TH7IqgwiFbQBSL23OfTqXMIJ5QVlDLbEgBaug9UEEtUhumFgKVFpCYgml7GeB/LU N+IyESoH13HCo4dGakEfpVa+sNKucMHlFfhUxNZFuSYzZfW9JzZmmtP9Sfaui04t wA0w67PTpXlClfLV59yNHQwlJU2iXj7NO3bjC4gYe6WUVpuh19gtxOEVeo2Wc77c J6h0YNWAPe3hso28dw1VKz4VuesnRAbFe03W75aMmWY8Q+2kChcg+SepPmsqjkq8 GD2JQpkliSeIQCtk6fe+htEqWDHS1c38Bl4PHKv+xgir5xM1LSpe65nK9G/AakNi 30rP9hIsgWew1x4R2LS86SXiDYe8H15wVA0sx5xyhzg5Q0RR9JSlyeRuAjLb4uRh b1D0LknJMWzGgJO8l2VM5MgfelPCT5+jk3H9BeqjNMrwdNaZjZo= =SeZp -----END PGP SIGNATURE----- --fnnxga2tdehpn7wt--