From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30860 invoked from network); 16 May 2022 10:19:55 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 16 May 2022 10:19:55 -0000 Received: (qmail 3440 invoked by uid 550); 16 May 2022 10:19:54 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 3405 invoked from network); 16 May 2022 10:19:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alyssa.is; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652696380; x=1652782780; bh=QPVDyh6woK aguJ28PxLFhN8gOUyg38jJhz0O4L8Eofs=; b=g6PWD22P9hNoHQc3+PPNwPERP7 6tXzrdufWh/4TP08C1Jeymin4ZY5tI073JTWkUythpz7vLv+XsZXcETytYPjZpRV c4CKBjH3h1n37st/z4eiFuGqzrKMqbhKvys0JGTxM5ekoMaxRPSjtN37xz2hWdLh qJgRxtgYduED9gP/buxEshhERRAdwk2z3OPPutzGJFrZHjNC/UmqpFyiOlx/zDAr 6nZ4Hy73QYD+18TKpyUOOSPecJ4W2bHRnfziMxFngb0dHCAL9fU0k2U9DRz6Y0oh 6576M2VB5nDVm+gtnx1jkAJhqZO7C/WIzHJuumS1+3tKUU1iULPu5U7xqKfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652696380; x= 1652782780; bh=QPVDyh6woKaguJ28PxLFhN8gOUyg38jJhz0O4L8Eofs=; b=B 7EXcV6nl3zfmUv02MrkZkrrtGE1rF5f+j6cFAaLqdK0CN6J/VVaRJsW/jWR/IgCv hAKdhTmxA09omU28rYkEJtf0q40NYccdxdYUwGwd0MoNf8OnjiNLNqAnu8qR5o5+ xcYsktHY1PwVZhGSqLmLX38kV/RozlgxKc18EzN7iZ5yfkOo7NaKfCFBH8Hp0XY1 HBM87tOv8MlSm6lVIJLbyQGKgDZ007Kz/wpOwnBp8HqjWOPtH1dv809FfsrY4zs9 NZhCIc1RAw1p9b17dmfKQKAxNLdM0v1Zb+3ylM2iIPdeGLOwFo2EL/O/RB1g1TEV UXIG73YwNndYvM0UzMo+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrheehgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesghdtre ertddtvdenucfhrhhomheptehlhihsshgrucftohhsshcuoehhihesrghlhihsshgrrdhi sheqnecuggftrfgrthhtvghrnhepvdegieefffekjefhvdfhtdffleetheejleeuhefhvd duieeuueegueejgfdttedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepqhihlhhishhssegvvhgvrdhqhihlihhsshdrnhgvth X-ME-Proxy: Date: Mon, 16 May 2022 10:19:38 +0000 From: Alyssa Ross To: Rich Felker Cc: musl@lists.openwall.com Message-ID: <20220516101938.b33b5ctmjqemoqdd@eve> References: <20210920042140.GT13220@brightrain.aerifal.cx> <20220109031819.GO7074@brightrain.aerifal.cx> <878rvj1tut.fsf@alyssa.is> <20220113174037.GA7074@brightrain.aerifal.cx> <875yqn1n8g.fsf@alyssa.is> <20220512140835.GJ7074@brightrain.aerifal.cx> <20220512180235.5uadgd4iyxtdr37p@eve> <20220512181553.GK7074@brightrain.aerifal.cx> <20220515183840.csmpbq36vd3mmhan@eve> <20220515231929.GP7074@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vlnkx7wqxt5ul4e3" Content-Disposition: inline In-Reply-To: <20220515231929.GP7074@brightrain.aerifal.cx> Subject: Re: [musl] [PATCH musl v2 3/3] mntent: fix parsing lines with optional fields --vlnkx7wqxt5ul4e3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 15, 2022 at 07:19:29PM -0400, Rich Felker wrote: > One more thing I missed: checking result of sscanf for EOF and > ferror(f) does not make sense; that would only make sense if it were > fscanf, but the FILE access already happened and was checked earlier. > Any objection to me just also removing that from the patch? That sounds fine to me. --vlnkx7wqxt5ul4e3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmKCJTgACgkQ+dvtSFmy ccBD5A/+KRD03KddDncmOTywn8aEdOw+NQNfFaXpdv3gYOPmjcuDq5I1YMS10Rw0 2fAdLpdu638e/0x7H7U9/tq7Y7R9cycdMuIT4ftXKvMJzcIExHDNx1JbvCSLtTck lpRItHgSFswfHM/dUysoqZ8dfsHpEHzILv628vQtH8pZ8Y+PP120RT2CD3dKWYiz I8iM8EdnJ0fSY3ZLJa40RQEwXP5mD3DoZR6cwamnCi8TBmj5mfo2HHNg/8ODbkb5 R0/9LvjZ/sRmrUusu/6gP3N1dyV2r4ZCzRw7nqdbL9c+C/927td/n/9L0Y4igXiZ BEhDD8M9es5X+llAlghpT4AU71BuGfGQNlZMBC5UKe8eydgm9GEXO5GL6QVhUKW2 KgyMqP0INMKa1yHIIdInCudoRT9suGXoBMfwF3tBnljIAG3GjjvdK+42pTbCwFKl PG2UmVLWz1CGQsbp7Rj4kpxJTtex0Rt3YzuIVhrwWhSZeo1+5blGicAfim7Rdr6v 79XYLT82Tddp02FY48OALDAtGBsFR9WttSDtlZTA0Bugaqxvbc6J4mENQ/S36idB Horw43spuHQYgA3rYQLGB56w43qavUp1QB3hNzXykgMfmyoqTs1XBFE9fbAJgCXn 8LexaZFfB4ENkxKRzACv1TYtFSehfOs43epJxQ0+ag7bP55uP0M= =iroo -----END PGP SIGNATURE----- --vlnkx7wqxt5ul4e3--