From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23251 invoked from network); 1 Aug 2022 17:55:49 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 1 Aug 2022 17:55:49 -0000 Received: (qmail 5502 invoked by uid 550); 1 Aug 2022 17:55:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5467 invoked from network); 1 Aug 2022 17:55:46 -0000 Date: Mon, 1 Aug 2022 13:55:33 -0400 From: Rich Felker To: Eugene Yudin Cc: musl@lists.openwall.com Message-ID: <20220801175533.GQ7074@brightrain.aerifal.cx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl][PATCH] make clock_getcpuclockid return ESRCH rather than EINVAL On Tue, Jun 14, 2022 at 01:15:36PM +0300, Eugene Yudin wrote: > Hi, > > According to man clock_getcpuclockid() should return ESRCH if there is no > process with the ID pid. > > diff --git a/src/time/clock_getcpuclockid.c b/src/time/clock_getcpuclockid.c > --- a/src/time/clock_getcpuclockid.c > +++ b/src/time/clock_getcpuclockid.c > @@ -8,6 +8,7 @@ int clock_getcpuclockid(pid_t pid, clockid_t *clk) > struct timespec ts; > clockid_t id = (-pid-1)*8U + 2; > int ret = __syscall(SYS_clock_getres, id, &ts); > + if (ret == -EINVAL) ret = -ESRCH; > if (ret) return -ret; > *clk = id; > return 0 > > The same behaviour is used in glibc: > https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/clock_getcpuclockid.c;h=5534127ed703a3931f22af48da02e2b8f2dc39a5;hb=HEAD#l49 Thanks, applying. Rich