From: "Érico Nogueira" <ericonr@disroot.org>
To: musl@lists.openwall.com
Cc: "Érico Nogueira" <ericonr@disroot.org>
Subject: [musl] [PATCH] remove extraneous syscall from fopen(3)
Date: Mon, 15 Aug 2022 14:50:21 -0300 [thread overview]
Message-ID: <20220815175021.16659-1-ericonr@disroot.org> (raw)
the __fdopen() call afterwards will set the close-on-exec flag with the
same syscall if "e" was specified in mode
---
src/stdio/fopen.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
index e1b91e12..22b72edf 100644
--- a/src/stdio/fopen.c
+++ b/src/stdio/fopen.c
@@ -20,8 +20,6 @@ FILE *fopen(const char *restrict filename, const char *restrict mode)
fd = sys_open(filename, flags, 0666);
if (fd < 0) return 0;
- if (flags & O_CLOEXEC)
- __syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
f = __fdopen(fd, mode);
if (f) return f;
--
2.37.2
next reply other threads:[~2022-08-15 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 17:50 Érico Nogueira [this message]
2022-08-15 17:54 ` Rich Felker
2022-08-15 17:58 ` Érico Nogueira
2022-08-15 18:16 ` Rich Felker
2022-08-15 18:31 ` Érico Nogueira
2022-08-15 18:57 ` Rich Felker
2022-08-20 8:49 ` Szabolcs Nagy
2022-08-20 8:52 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815175021.16659-1-ericonr@disroot.org \
--to=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).