mailing list of musl libc
 help / color / mirror / code / Atom feed
* [musl] [PATCH] remove extraneous syscall from fopen(3)
@ 2022-08-15 17:50 Érico Nogueira
  2022-08-15 17:54 ` Rich Felker
  0 siblings, 1 reply; 8+ messages in thread
From: Érico Nogueira @ 2022-08-15 17:50 UTC (permalink / raw)
  To: musl; +Cc: Érico Nogueira

the __fdopen() call afterwards will set the close-on-exec flag with the
same syscall if "e" was specified in mode
---
 src/stdio/fopen.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/stdio/fopen.c b/src/stdio/fopen.c
index e1b91e12..22b72edf 100644
--- a/src/stdio/fopen.c
+++ b/src/stdio/fopen.c
@@ -20,8 +20,6 @@ FILE *fopen(const char *restrict filename, const char *restrict mode)
 
 	fd = sys_open(filename, flags, 0666);
 	if (fd < 0) return 0;
-	if (flags & O_CLOEXEC)
-		__syscall(SYS_fcntl, fd, F_SETFD, FD_CLOEXEC);
 
 	f = __fdopen(fd, mode);
 	if (f) return f;
-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-20  8:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 17:50 [musl] [PATCH] remove extraneous syscall from fopen(3) Érico Nogueira
2022-08-15 17:54 ` Rich Felker
2022-08-15 17:58   ` Érico Nogueira
2022-08-15 18:16     ` Rich Felker
2022-08-15 18:31       ` Érico Nogueira
2022-08-15 18:57         ` Rich Felker
2022-08-20  8:49       ` Szabolcs Nagy
2022-08-20  8:52         ` Szabolcs Nagy

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).