From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30526 invoked from network); 24 Aug 2022 18:47:20 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 24 Aug 2022 18:47:20 -0000 Received: (qmail 29869 invoked by uid 550); 24 Aug 2022 18:47:17 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 29837 invoked from network); 24 Aug 2022 18:47:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661366825; bh=Ctwll99JEgHB/0Qt6aRRfyWeJUqvUoL6VKu1g61jlTs=; h=X-UI-Sender-Class:Date:From:To:Subject:References:In-Reply-To; b=TGHFe17ggTmtj/rNPi4aJbouEPvAPH1BUUIr4+u0US4Sf8WWhumbe9+Tj+rohjCjk /60UOnfEev0gbfQPWD/GTuFQd0ku18D2BJMRYCimmsBPj+Y1PYbzp9Con7JlHe04IM L8L9p1zew0QgCVEdZnYGOlGOQMTORwf4BM/xhZ0g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Date: Wed, 24 Aug 2022 20:47:04 +0200 From: Markus Wichmann To: musl@lists.openwall.com Message-ID: <20220824184704.GA1923@voyager> References: <20220824142652.1424306-1-kristina.martsenko@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824142652.1424306-1-kristina.martsenko@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Provags-ID: V03:K1:Xap99/Aus7rhFQvatwqp9DkPp1SJ8cZTprVqxaUDlTm+iMS/A9M QiPLtt/6V8o9JfVbiBlFhKoA5rCW4d8IskNJmCYYCyyA8QxS5kPyaQL0DinfYyPWbOLc2iy qdpbt+ANtmBGLRMUF/O/c9Uf+yj0t2u29mMCwgdZOd2TTqsSkmerRsWr254F2goXdDiC0QS uedsFXOIPdwluTL34w3jA== X-UI-Out-Filterresults: notjunk:1;V03:K0:MNQX+maiZOY=:AKXeJj+rxxvF6KYSI1bx4O H7Z1p+KA64d0PPTFThqAkIO89dkD6UnEUlMb++ZIyRKZ5tHhuy8LjmcjSOVfWwlQvu+Dx+mIA Z+0xXn8rVI7RbkPhgckIy4yOSRpaBWeQC+2JdYHJqdLzaPo9zY2QvvnSsMiC8/VoO1kwuIsBF 9LwU9ZlY0puCFDJJP4DyJVvjF/TK2kIRti6ja8DH7jr7nwAAMYekgYGSWp6ZqY8YCiUZ1CJlX jl4cuBwzqf4zkJNm15NUwfxKwSrVY5/UeNT7JJ+5W3cIoFnEMjoR1Xvw8FzD/Elu8cK32CL64 uutdiGAS4F6lspAeOLAbfNP2NnZ+yP6jLk0JsQLymWWG50WyhzWeXYh41E10zyzLrZM8vProD KvRlp6bTKNZP9XHUwcYpx+fzcafYSgn6+5NiQ+b6TSC9IWgic3lda1rO2zKnxPsS8r/h+kHm0 ULEVfboKzQyXCDWQjksr1uudGgnXo7pnnW35HwPZ6OkuL/a3RHGjCPI6PsveETMmzu9OWCKNo FCBZUC6ds3vOctEITPwmJ7JcaQpSl1xAWYJhSuECn90E/8x7su9cyj/zxRxLeUxPYYDK9GdZe aMATztw/3gfk8yC7AQhZFqcsTD4DicxI29H8e0hPW5cGcTxnbedShqdvJQjaocEGbmEe0QIoX bUCrkgv6VegSoO12W4jXARtuc2dbG6yLf6GyIiAybkdqJZ8GEUw9wkFHBGfnHPY0hvfZF3CZQ HAbbhKfIuAIQYaWEF66eaIPrezvD+2lczDyYbTAbz6NhEBVZBgqJ3BEBdUwTwddc84SYNaRZR 9Ju1u10bVwLRLVqhfCXREmPRE0UrStFRHYh/abwPq8lykb9vx+jQvkGR5YfF8tzzD57F1LvG3 Ogxt/qUpfHHycmEh9nupvD8cCUDcDTlEc+6y4PRmKDu0KXw2Jy3Hfye0HxWXxDwIuLbIyFLZg ZBRB48G/Mep50HO/kDP7lVIbEEUXL0S3OpEjHefG/gPZ5aHOOycIO7WG2zi7V8nhIaI3tfZLX KXYYL/FQAAt25N6w1WQ73XP/ddQpCnKYDGqLiXTtdxK8Pt7Jo3W6deXJEkbvkMT8GLrA4VYZn 3c6yZscbn/gutR0wvfm6Zoy/1riWmeG9eWpw2hT+Q7hM6U1DYOO8QnYQg== Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] [PATCH] epoll: return EINVAL from epoll_create() if size is non-positive On Wed, Aug 24, 2022 at 03:26:52PM +0100, Kristina Martsenko wrote: > The man page for epoll_create() states that the 'size' argument must be > positive, otherwise EINVAL is returned. musl currently ignores the > argument and does not return EINVAL. Change it to match the man page. > > Worth noting that this is needed for an LTP (Linux Test Project) test to > pass (epoll_create02). I am wondering if this change is sensible. On musl, the size argument is never handed to the kernel. Failing for nonpositive arguments may be in the spec, but it might make users assume the argument is actually used. But it isn't. epoll_create() always calls epoll_create1(), and that function falls back to the epoll_create syscall with a constant argument of 1 if epoll_create1 is not available. Ciao, Markus