From: Rich Felker <dalias@libc.org>
To: Markus Wichmann <nullplan@gmx.net>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH] epoll: return EINVAL from epoll_create() if size is non-positive
Date: Wed, 24 Aug 2022 19:34:37 -0400 [thread overview]
Message-ID: <20220824233437.GN7074@brightrain.aerifal.cx> (raw)
In-Reply-To: <20220824184704.GA1923@voyager>
On Wed, Aug 24, 2022 at 08:47:04PM +0200, Markus Wichmann wrote:
> On Wed, Aug 24, 2022 at 03:26:52PM +0100, Kristina Martsenko wrote:
> > The man page for epoll_create() states that the 'size' argument must be
> > positive, otherwise EINVAL is returned. musl currently ignores the
> > argument and does not return EINVAL. Change it to match the man page.
> >
> > Worth noting that this is needed for an LTP (Linux Test Project) test to
> > pass (epoll_create02).
>
> I am wondering if this change is sensible. On musl, the size argument is
> never handed to the kernel. Failing for nonpositive arguments may be in
> the spec, but it might make users assume the argument is actually used.
> But it isn't. epoll_create() always calls epoll_create1(), and that
> function falls back to the epoll_create syscall with a constant argument
> of 1 if epoll_create1 is not available.
Being that it's documented to fail with EINVAL for nonpositive
arguments, I think we should do that, even if the argument is
otherwise ignored.
Rich
prev parent reply other threads:[~2022-08-24 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 14:26 Kristina Martsenko
2022-08-24 18:47 ` Markus Wichmann
2022-08-24 23:34 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824233437.GN7074@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=nullplan@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).