From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1993 invoked from network); 6 Sep 2022 18:48:49 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 6 Sep 2022 18:48:49 -0000 Received: (qmail 30634 invoked by uid 550); 6 Sep 2022 18:48:46 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 30596 invoked from network); 6 Sep 2022 18:48:45 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1662490108; bh=9/62WGNWO2z72ZjoNxXjePcG//IAh2y7TMwIE94qnyk=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=Cxr4uZ0cRLXM5WkTDGPyEH6E1J4S7Fn+EyAqNTFMA3em0PY/TN4kzcXIVI9SAi5NJ gpJndNUnekuAKzOJGYXKa/75F26Ny5QGLoHewRtDq7lYS7Kk0eOnLVLbrMmQ4UCRPS t1e8UNKK61VeWcRpce/Isef+eHl3JWvM5KjlkMNo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Date: Tue, 6 Sep 2022 20:48:26 +0200 From: Markus Wichmann To: musl@lists.openwall.com Cc: Gabriel Ravier , Joakim Sindholt Message-ID: <20220906184826.GA1649@voyager> References: <7bf9a30d-4ba8-1fe7-8c80-db99446db307@gmail.com> <6c1dfc63-b3e8-46a3-1db1-4d5bdf031086@gmail.com> <20220906141311.b8650027f3499c080f45b4fd@zhasha.com> <166c0b26-198a-91d3-08c9-ba135fc57065@gmail.com> <20220906141736.GC9709@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220906141736.GC9709@brightrain.aerifal.cx> User-Agent: Mutt/1.9.4 (2018-02-28) X-Provags-ID: V03:K1:U3CUvKdqKfDLji1jPQFdlA6uQV1qVHvHomd4mJA6nfPGZLGsSPN OwYhNyWNPxguEJWAB+WyobtHGuzzrjUlbJ12vFg95YCt4XVGNUtCcGCfZEwhWHYlQXsLZZj QnRBmCDJB40LTJrJIic939K53V+QoenV7oO5HKeQ/tsr1aeUSpqqdtYbJnxeX08VsAQz53q 6IlIN4uPuSN8QgYedRt+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ipcag4QhH1E=:IIwvswYtI1RIJX9EJ+XYN1 D59Ivl/Pf/B5DdhfnAzPIfsdZO8bJsjdlxZn0+EgxrfK8hXHLQBivO8kMVkUU+ua6p1JJtwDV egvDu1gg0ZbSUcyryzAxoMO0ktHguoym+7aU62DTEpHOD+ftFFpMSpBtKZuYE5TQWi3WcBjbk 0tU7XYNy9iIGvjgXYUijFg9zk5mwWkw6O06SfzokLa1J86THhq0I3FaqXgbF0LaGhvTtlIe3T dEGBpXoaEVqX36UNuhaFbsmh7Ey6CKQROJhhT9VmKgF3PNbQ1k4yEQ1mbhMBdVZirqEa/nSbf 2T/EZzWNAgOPQyXg2wm+DTakzPD0w8mJlieMv6THPn4JyKlG0iwPfZ6YM2diw9+oqoLRk+PHC Cz+TCXJrxQmypkHdSmONcy4t76eOkX++nlVPP6R5Q7dAePUlZJ6V2RJR4MeT+GtW1fH03tiSh JMwkbPAgIJTmpuzoakf2aUJEEY5p/xNsgYqM3QOf3orGELNBxjEZxs7tmeMOpbKp++PVB2sa4 HBm4EK9feQV8419RLf5ZxvMgb5PJVbi5H3YzRHOQu6/ZMKU7MR5KD4Pa8UWYRL3N7ZAZ6UEjc MBlKSp+sI8jfe/bNxEFwW/60VQF6U2itd6DZo92T0nSqm2X2/FEUCWorxvggYxEmiH4YpumVZ wkfLcBjdS6+W/a+kTDZmSIPCoAVO2HzDFU/Xngvkf14VHnMnElXtmH/NUMvBBEDYG2OkGNkv4 ns9oClAbE3vRdk5f5kjW2wns5KfAjf3LbTWxYLNBprEnI+m51XYpnBXl1PvS19VNaY/7dmcBz QeK+QPRR2uM+sTtGrxUofdcDl3GNF79rjleRJgj16ZJIm8FOoRRB3OJIwU54aPnWre3EUlcG/ 6S/jt+LDexy2orI2ZS+Prt25Te/drLdBtGCh5dSuScauAM0k+cz5yYYUYefyLBXj9Z0i3GV2O KEV8hg95QoDJGlIEjvsQzX6s0nduc64twOd1q6fXjDfLVe/ylnl58KEd5UKL4xO6v2Om02Hjv 5DCcgIr5ayK9mMI78MMqW9jpGJDsb55VJUouTY6pPUoQRHO+aBpUBFyEoWO7Y3sdFkjqCyHFj m9Mkh+5M0alj3LVfImZCFi40HQSRJy0P+HrIUcLiEje7KnLN/DO2Bg4opM3cmris7+vvIbPyy fSS+kbeq/Y5s3F82POv1XSHah5 Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] ecvt(0, 0, ...) is broken On Tue, Sep 06, 2022 at 10:17:36AM -0400, Rich Felker wrote: > But these are garbage functions. The > right answer is to fix whatever is using them to use snprintf and move > on. > > Rich > > Well, then why not remove them from the lib? Any program using them would invoke a link failure. Indeed, for GCC, the declarations could be retained and an error attribute be added. Configure tests would fail to find these functions and possibly switch on alternative paths. Of course, that is not ABI compatible. But isn't excising broken functions better than retaining them? Because as the OP showed, our implementations are not behaving as some callers would expect. Ciao, Markus