mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Ken Mays <kmays2000@gmail.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] POSIX compliance testing of strftime
Date: Mon, 12 Sep 2022 17:47:40 -0400	[thread overview]
Message-ID: <20220912214739.GK9709@brightrain.aerifal.cx> (raw)
In-Reply-To: <CA+kJofexgF7LKue+RcNHOVKfgkijpvyAENuRaPuuXbb+mShsgQ@mail.gmail.com>

On Mon, Sep 12, 2022 at 01:32:28PM -0700, Ken Mays wrote:
> Hello,
> 
> I am doing POSIX compliance testing of strftime on HAIKU (w/MUSL)
> using the Open POSIX Test Suite v1.5.2 located here:
> 
> Open POSIX Test Suite - Browse Files at SourceForge.net
> <https://sourceforge.net/projects/posixtest/files/>
> 
> Specifically:
> 
> open_posix_testsuite/1-1.c at master · haiku/open_posix_testsuite
> (github.com) <https://github.com/haiku/open_posix_testsuite/blob/master/conformance/interfaces/strftime/1-1.c>
> 
> and
> 
> open_posix_testsuite/2-1.c at master · haiku/open_posix_testsuite
> (github.com) <https://github.com/haiku/open_posix_testsuite/blob/master/conformance/interfaces/strftime/2-1.c>
> 
> Issue: MUSL's strftime only fails one minor test for both test 1-1 and 2-1.
> 
> I'd like to know if a MUSL developer could review the mentioned tests?
> 
> Are there known issues with strftime with POSIX compliance testing?
> 
> Thanks,
> 
> ~K

When reporting test failures, could you report *which test* (not just
which files, but which particular assertion they're trying to make) is
failing? It would have saved a lot of time not having to get, compile,
and run them. But now after doing that, I can't even reproduce any
failures; I just get all PASS. So in order to investigate at all I
really need to know what specific failures you hit.

FWIW these are rather dubious tests since they depend on the current
time when the test is run and the user's locale. Perhaps the failures
you saw were dependent on those factors?

Rich

  reply	other threads:[~2022-09-12 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 20:32 Ken Mays
2022-09-12 21:47 ` Rich Felker [this message]
2022-09-12 22:11   ` Ken Mays

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220912214739.GK9709@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=kmays2000@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).