From: Rich Felker <dalias@libc.org>
To: Markus Wichmann <nullplan@gmx.net>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Revisiting LFS64 removal
Date: Mon, 26 Sep 2022 12:47:14 -0400 [thread overview]
Message-ID: <20220926164713.GD9709@brightrain.aerifal.cx> (raw)
In-Reply-To: <20220926160332.GB2645@voyager>
On Mon, Sep 26, 2022 at 06:03:32PM +0200, Markus Wichmann wrote:
> On Sun, Sep 25, 2022 at 09:03:40PM -0400, Rich Felker wrote:
> > Seeing a recent wrong-fix commit in binutils
> > (https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fe39ffdc202f04397f31557f17170b40bc42b77a)
> > reminded me of the longstanding "we need to remove LFS64" issue.
> >
>
> Whenever I see stuff like that, it makes me break out in hives. The
> stupidest part is that the commit is adding configure tests, so they
> could just test for the things they want. But no, they test for
> something unrelated and then assume that that has the implications they
> want.
Exactly.
> > I believe the simplest short-term way is probably going to be just
> > having the dynamic linker symbol lookup error path make one final
> > check before bailing out with an error:
> >
> > - If the symbol to lookup ends in "64"..
> > - ..and it's in a hard-coded list of LFS64-compat symbols..
> > - ..and looking up the name with the "64" removed in libc succeeds..
> >
> > Then use the version without the "64" suffix and go on with relocation
> > processing.
> >
>
> Took me a while to figure out what you were trying to do here: You want
> to hide the LFS64 symbols at link-time. At compile-time, the macros
> prevent actual use of those symbols, at link-time, access will fail, but
> the symbols will still be there at dynamic load-time, so existing
> binaries don't break.
>
> Of course, that means that you will have to keep the kludge around for
> the foreseeable future, as even if those symbols are added to
> libgcompat, existing binaries would break if it were removed (since
> existing binaries do not depend on libgcompat), which violates the musl
> ABI stability goals. Oh well, it's not going to be the last bit of
> legacy cruft in the library.
No, that's not the case. ABI stability is only guaranteed for ABIs
that result from use of the public APIs. If you pull in a symbol that
was accidentally exposed by not marking it hidden, or by manually
declaring some glibc-ABI-compat symbol that's not part of the public
API, or anything like that, you get to keep both parts when it breaks.
OTOH if a public API generates a reference to a symbol, then that
symbol is stable ABI.
Rich
next prev parent reply other threads:[~2022-09-26 16:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 1:03 Rich Felker
2022-09-26 16:03 ` Markus Wichmann
2022-09-26 16:47 ` Rich Felker [this message]
2022-09-26 22:04 ` Rich Felker
2022-09-27 9:09 ` Gabriel Ravier
2022-09-27 12:20 ` Rich Felker
2022-09-27 19:03 ` Rich Felker
2022-09-27 19:08 ` Rich Felker
2022-09-29 23:07 ` Rich Felker
2022-09-30 2:44 ` Markus Wichmann
2022-09-30 12:57 ` Rich Felker
2022-09-30 17:35 ` Colin Cross
2022-09-30 18:13 ` enh
2022-09-30 19:26 ` Rich Felker
2022-09-30 23:03 ` enh
2022-09-30 19:29 ` Rich Felker
2022-09-30 19:41 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926164713.GD9709@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=nullplan@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).