From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4656 invoked from network); 9 Oct 2022 10:36:09 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 9 Oct 2022 10:36:09 -0000 Received: (qmail 7953 invoked by uid 550); 9 Oct 2022 10:36:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 7918 invoked from network); 9 Oct 2022 10:36:01 -0000 Date: Sun, 9 Oct 2022 12:35:50 +0200 From: Szabolcs Nagy To: Markus Wichmann Cc: musl@lists.openwall.com Message-ID: <20221009103550.GJ2158779@port70.net> Mail-Followup-To: Markus Wichmann , musl@lists.openwall.com References: <20221009084508.GB2442@voyager> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221009084508.GB2442@voyager> Subject: Re: [musl] Why thousands of digits in floatscan.c? * Markus Wichmann [2022-10-09 10:45:08 +0200]: > Hi all, > > so I recently read this wonderful paper: https://dl.acm.org/doi/10.1145/103162.103163 > > Great read, I encourage it for everyone, even though some things are not > directly applicable to the C application programmer. > > Anyway, towards the end of the paper, Goldberg makes the argument that a > 9 digit decimal number is always enough to uniquely identify a > single-precision number. Generalizing out from his argument, I > calculated that 36 decimal digits are needed for a quad-precision number > (the digit count for a w bit mantissa is roundup(w * lg 2) + 1, which is > 9 for single-prec, 17 for double-prec, 21 for double-extended, and 33 > for double-double). this is {FLT,DBL,LDBL}_DECIMAL_DIG > > Now, I looked again at floatscan.c. The algorithm in decfloat() mostly > consists of reading all the decimal digits into a base 1 billion number, > which could have any length at all, then aligning the radix point with a > word boundary, and then shifting that number such that exactly one > mantissa worth of bits are left of the radix point. For the most part, > the algorithm does not care about the remaining bits except for two bits > of information: If the tail is equal to 0, or else how it compares to > 0.5. So now I am left wondering why then, if only the first > LDBL_MANT_DIG bits of the number, plus two more for the tail, ever count > for anything, the algorithm makes room for thousands of decimal digits. > Would it not be enough to save a few dozen? What purpose do the far-back > digits have? *_DECIMAL_DIG is enough if we know the digits are the decimal conversion of an actual fp number of the right type and right rounding mode. but e.g. it can be the digits of a number halfway between two fp numbers exactly. that sequence of digits would never occur when an actual fp number is printed but it is still a valid input and has to be read to the end to decide which way to round. (assuming nearest rounding mode.) the worst case is halfway between {FLT,DBL,LDBL}_TRUE_MIN and 0. and the digits of that would be 2^{-150,-1075,-16495} = 5^{150,..} * 10^{-150,..} i.e. 0. followed by many zeros and then the digits of 5^16495. depending on the last digit it has to be rounded up or down. > > To be clear, I am totally aware of why there needs to be room for > thousands of digits in fmt_fp(): All of those digits are in the number > and could be requested. The smallest representable positive number on > the PC is 2^-16447 (that is, it has an exponent of -16384 and a > mantissa of 2^-63), and that is a number with 16447 decimal places > (though the first 4950 of those are 0 and don't need to be saved > explicitly, but then you'd need wrap-around semantics there as well). > > Ciao, > Markus