Re: [musl] [PATCH] pthread_atfork: fix return value on malloc failure

[Rich Felker <dalias@libc.org>]

On Sun, Nov 13, 2022 at 04:20:23PM +0100, Szabolcs Nagy wrote:
> * Alexey Izbyshev <izbyshev@ispras.ru> [2022-11-12 16:31:01 +0300]:
> > POSIX requires pthread_atfork to report errors via its return value,
> > not via errno. The only specified error is ENOMEM.
> 
> this patch looks good.

Yes, looks good to me. Taking it with just one style thing changed
(not spelled out anywhere): generally source files keep the header for
the interface they're defining at the very top, with headers for
interfaces they use below that.

> 
> 
> > ---
> >  src/thread/pthread_atfork.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/thread/pthread_atfork.c b/src/thread/pthread_atfork.c
> > index 76497401..2fbe23ca 100644
> > --- a/src/thread/pthread_atfork.c
> > +++ b/src/thread/pthread_atfork.c
> > @@ -1,3 +1,4 @@
> > +#include <errno.h>
> >  #include <pthread.h>
> >  #include "libc.h"
> >  #include "lock.h"
> > @@ -34,7 +35,7 @@ void __fork_handler(int who)
> >  int pthread_atfork(void (*prepare)(void), void (*parent)(void), void (*child)(void))
> >  {
> >  	struct atfork_funcs *new = malloc(sizeof *new);
> > -	if (!new) return -1;
> > +	if (!new) return ENOMEM;
> >  
> >  	LOCK(lock);
> >  	new->next = funcs;
> > -- 
> > 2.37.2