mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Jₑₙₛ Gustedt" <jens.gustedt@inria.fr>
To: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
Cc: musl@lists.openwall.com, Reini Urban <reini.urban@gmail.com>
Subject: Re: [musl] C23 implications for C libraries
Date: Wed, 23 Nov 2022 09:11:09 +0100	[thread overview]
Message-ID: <20221123091109.36e2bdf2@inria.fr> (raw)
In-Reply-To: <CAE2XoE9esb+23NfWGBnyNy1khdMrWJgTZkv976W8qrupMOFFEQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

罗勇刚,
there might be a misunderstanding here, this page is not meant for
musl alone and the example code is just that, example code. How C
library implementations then do it is clearly a question of their
particular coding style.

on Wed, 23 Nov 2022 12:31:27 +0800 you (罗勇刚(Yonggang Luo)
<luoyonggang@gmail.com>) wrote:

> I have concern about the macros guard with __cplusplus and
> __STDC_VERSION__
> 
> #if (__cplusplus >= 201103L) || (__STDC_VERSION__ >= 202311L)
> #define NULL nullptr
> #elif defined(__cplusplus)
> #define NULL 0L              /* Any of 0, 0L, 0LL as wide as a void*
> */ #else
> #define NULL ((void*)0)
> #endif
> 
> 
> I think all of these should be guarded with
> #if (defined(__cplusplus) && (__cplusplus >= 201103L)) ||
> (defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 202311L))
> 
> this is safer to avoid -Wundef complain it

IIRC musl's strategy has so far been to use the implicit 0 rule for
identifiers in preprocessor conditionals. But I may be mistaken.

Also, `__STDC_VERSION__` has been introduced in C95, I think, do we
even support compilers that don't have this?

Thanks
Jₑₙₛ

-- 
:: INRIA Nancy Grand Est ::: Camus ::::::: ICube/ICPS :::
:: :::::::::::::::::::::: gsm France : +33 651400183   ::
:: ::::::::::::::: gsm international : +49 15737185122 ::
:: http://icube-icps.unistra.fr/index.php/Jens_Gustedt ::

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2022-11-23  8:11 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 14:25 Jₑₙₛ Gustedt
2022-09-23 14:58 ` Rich Felker
2022-09-23 15:11   ` Alexander Monakov
2022-09-23 15:35   ` Jₑₙₛ Gustedt
2022-09-23 15:28 ` enh
2022-09-23 15:40   ` Jₑₙₛ Gustedt
2022-09-23 23:52     ` enh
2022-09-24  7:31       ` Jₑₙₛ Gustedt
2022-09-26  3:18         ` Damian McGuckin
2022-09-26  3:33         ` Rich Felker
2022-09-26 10:49         ` Florian Weimer
2022-09-26 12:52           ` Jₑₙₛ Gustedt
2022-09-26 20:13         ` enh
2022-11-18 20:46 ` 罗勇刚(Yonggang Luo)
2022-11-19 14:33   ` Jₑₙₛ Gustedt
2022-11-19 17:19     ` 罗勇刚(Yonggang Luo)
2022-11-20  8:23       ` Jₑₙₛ Gustedt
2022-11-19 18:28     ` Rich Felker
2022-11-20  8:42       ` Jₑₙₛ Gustedt
2023-05-03 22:58     ` enh
2023-05-04  6:19       ` Jₑₙₛ Gustedt
2023-05-04 16:03         ` Rich Felker
2023-05-04 16:07           ` enh
2023-05-04 23:16             ` Gabriel Ravier
2023-05-05  0:37               ` JeanHeyd Meneide
2023-05-05  6:56                 ` Jₑₙₛ Gustedt
2023-05-05 12:40                   ` Rich Felker
2023-05-05  6:40             ` Jₑₙₛ Gustedt
2023-05-04 16:03         ` enh
2023-05-04 23:11           ` Gabriel Ravier
2022-11-19 18:31   ` Rich Felker
2022-11-20  4:25     ` 罗勇刚(Yonggang Luo)
2022-11-20  5:34       ` Markus Wichmann
2022-11-21 11:46 ` Reini Urban
2022-11-21 21:06   ` Jₑₙₛ Gustedt
2022-11-23  4:31     ` 罗勇刚(Yonggang Luo)
2022-11-23  8:11       ` Jₑₙₛ Gustedt [this message]
2022-11-23  8:20         ` 罗勇刚(Yonggang Luo)
2022-11-23  8:33           ` Jₑₙₛ Gustedt
2022-11-23  8:41             ` 罗勇刚(Yonggang Luo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123091109.36e2bdf2@inria.fr \
    --to=jens.gustedt@inria.fr \
    --cc=luoyonggang@gmail.com \
    --cc=musl@lists.openwall.com \
    --cc=reini.urban@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).