mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Cc: Peter Collingbourne <pcc@google.com>
Subject: Re: [musl] [PATCH] arm: Use __WCHAR_TYPE__ for wchar_t if defined
Date: Sun, 5 Feb 2023 21:00:03 +0100	[thread overview]
Message-ID: <20230205200003.GA1998@voyager> (raw)
In-Reply-To: <CQ9L8J42M5SC.2KNL0F70AM877@sumire>

On Sat, Feb 04, 2023 at 08:08:36AM +0100, alice wrote:
> On Sat Feb 4, 2023 at 7:30 AM CET, Peter Collingbourne wrote:
> > When building with -fshort-wchar the definition of wchar_t is
> > incorrect. Get the correct definition from the compiler if available.
> >
> > This is useful when reusing the freestanding parts of musl on a
> > bare-metal target that uses -fshort-wchar.
>
> somebody talked about this in 2015, see
> https://www.openwall.com/lists/musl/2015/02/18/2
> for the previous discussion.
>
> i understand in this case it's proposed a little different-
> "reusing freestanding parts" as opposed to building a whole libc.so, but in
> that case you could most likely patch this in when reusing it standalone only?
>
> it doesn't seem a good idea for it to be there, in general.

Seconded. A lot of code in musl depends on wchar_t being able to hold
the current maximum Unicode codepoint of 0x10FFFF at least, so the type
must be at least 21 bits.

Ciao,
Markus

  reply	other threads:[~2023-02-05 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04  6:30 Peter Collingbourne
2023-02-04  7:08 ` alice
2023-02-05 20:00   ` Markus Wichmann [this message]
2023-02-05 23:49     ` Rich Felker
2023-02-07  1:15       ` Peter Collingbourne
2023-02-07 14:59         ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230205200003.GA1998@voyager \
    --to=nullplan@gmx.net \
    --cc=musl@lists.openwall.com \
    --cc=pcc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).