From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 12767 invoked from network); 11 Feb 2023 19:30:59 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 11 Feb 2023 19:30:59 -0000 Received: (qmail 21855 invoked by uid 550); 11 Feb 2023 19:30:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 21820 invoked from network); 11 Feb 2023 19:30:56 -0000 Date: Sat, 11 Feb 2023 14:30:44 -0500 From: Rich Felker To: Bastian Bittorf Cc: musl@lists.openwall.com, mailinglist Message-ID: <20230211193044.GM4163@brightrain.aerifal.cx> References: <20230211125147.7ud3rx2ozflm7zsb@email> <20230211140103.GE4163@brightrain.aerifal.cx> <20230211192739.zfizfkfe5xiwikjb@email> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230211192739.zfizfkfe5xiwikjb@email> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] busybox problem on powerpc PPC/32bit (hardware TP-Link-WDR-4900-v1) On Sat, Feb 11, 2023 at 07:27:39PM +0000, Bastian Bittorf wrote: > On Sat, Feb 11, 2023 at 09:01:03AM -0500, Rich Felker wrote: > > It looks like the powerpc spe longjmp code is clobbering the value > > argument. Try the attached patch. > > > diff --git a/src/setjmp/powerpc/longjmp.S b/src/setjmp/powerpc/longjmp.S > > index 611389fe..465e4cd7 100644 > > --- a/src/setjmp/powerpc/longjmp.S > > +++ b/src/setjmp/powerpc/longjmp.S > > @@ -42,10 +42,10 @@ longjmp: > > bl 1f > > .hidden __hwcap > > .long __hwcap-. > > -1: mflr 4 > > - lwz 5, 0(4) > > - lwzx 4, 4, 5 > > - andis. 4, 4, 0x80 > > +1: mflr 6 > > + lwz 5, 0(6) > > + lwzx 6, 6, 5 > > + andis. 6, 6, 0x80 > > beq 1f > > .long 0x11c35b01 /* evldd 14,88(3) */ > > .long 0x11e36301 /* ... */ > > Thanks a lot, this looked promising!, but > sorry, it does NOT solve the issue: > > Using musl-cross-make and this file in > patches/musl-1.2.0/ppc-spe-longjmp-fix.diff > i compiled an output/bin/powerpc-linux-muslsf* > crosscompiler with: > make TARGET=powerpc-linux-muslsf install > and used it for further steps... > > maybe the patch did not applied? > let me sleep about it... > > Thanks a lot, Bastian If busybox is static linked, you need to be sure you're linking against the new libc.a built with the patch applied. If it's dynamic linked, you need to make sure the shared libc is installed on the system (but you can use the newly-built patched libc.so *as a command* to run the dynamic busybox binary and test it). Rich