From: Markus Wichmann <nullplan@gmx.net>
To: musl@lists.openwall.com
Subject: Re: [musl] Re: [BUG] ioctl: overflow in implicit constant conversion
Date: Tue, 21 Feb 2023 22:28:42 +0100 [thread overview]
Message-ID: <20230221212842.GG1903@voyager> (raw)
In-Reply-To: <CAH8yC8nTVCv_UWnm-NxYmo2ek66np9xOR4Mu7b1mQ63jU03ZdA@mail.gmail.com>
On Tue, Feb 21, 2023 at 11:57:50AM -0500, Jeffrey Walton wrote:
> In this case, I think the best course of action is to cast a,b,c to
> unsigned, then perform the shifts, and finally cast back to int. That
> is what the C standard requires. And it should not mess with the ABI.
>
Actually I messed up. That mostly happens already. The directions are
defined as unsigned, and the conversion to int happens implicitly. So
there is no undefined behavior. The compiler is merely warning about
nothing. That also means the only thing missing to silence the warning
would be a cast back to int. However, we have in the past never added
code just to shut up overeager warnings. Should the compiler not
suppress warnings that come from system headers?
Ciao,
Markus
next prev parent reply other threads:[~2023-02-21 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 5:26 Ralph Little
2023-02-21 16:04 ` Markus Wichmann
2023-02-21 16:42 ` Florian Weimer
2023-02-21 16:53 ` alice
2023-02-21 16:57 ` Jeffrey Walton
2023-02-21 18:25 ` Ralph Little
2023-02-21 21:28 ` Markus Wichmann [this message]
2023-02-22 6:33 ` NRK
2023-02-22 3:17 ` Rich Felker
2023-02-22 4:23 ` Markus Wichmann
2023-02-22 15:53 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221212842.GG1903@voyager \
--to=nullplan@gmx.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).