From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 26286 invoked from network); 29 Mar 2023 17:16:59 -0000
Received: from second.openwall.net (193.110.157.125)
  by inbox.vuxu.org with ESMTPUTF8; 29 Mar 2023 17:16:59 -0000
Received: (qmail 7654 invoked by uid 550); 29 Mar 2023 17:16:56 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 7619 invoked from network); 29 Mar 2023 17:16:55 -0000
Date: Wed, 29 Mar 2023 19:16:43 +0200
From: Szabolcs Nagy <nsz@port70.net>
To: Matthias Goergens <matthias.goergens@gmail.com>,
	musl@lists.openwall.com
Message-ID: <20230329171643.GE3630668@port70.net>
Mail-Followup-To: Matthias Goergens <matthias.goergens@gmail.com>,
	musl@lists.openwall.com
References: <20230329151751.392944-1-matthias.goergens@gmail.com>
 <20230329170418.GD3630668@port70.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230329170418.GD3630668@port70.net>
Subject: Re: [musl] [PATCH] mntent: deal with escaped whitespace in mtab and
 fstab

* Szabolcs Nagy <nsz@port70.net> [2023-03-29 19:04:18 +0200]:
> > -	return fprintf(f, "%s\t%s\t%s\t%s\t%d\t%d\n",
> > -		mnt->mnt_fsname, mnt->mnt_dir, mnt->mnt_type, mnt->mnt_opts,
> > -		mnt->mnt_freq, mnt->mnt_passno) < 0;
> 
> the original code has a bug here: fprintf returns number of
> chars printed but addmntent returns 0 to indicate success.

sorry missed the < 0.