From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32700 invoked from network); 5 Apr 2023 12:21:00 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 5 Apr 2023 12:21:00 -0000 Received: (qmail 11878 invoked by uid 550); 5 Apr 2023 12:20:57 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 11855 invoked from network); 5 Apr 2023 12:20:56 -0000 Date: Wed, 5 Apr 2023 08:20:44 -0400 From: Rich Felker To: Florian Weimer Cc: musl@lists.openwall.com Message-ID: <20230405122044.GG4163@brightrain.aerifal.cx> References: <20230405115445.GG3298@brightrain.aerifal.cx> <874jpule77.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874jpule77.fsf@oldenburg.str.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Re: [PATCH v9 0/13] implement dlmem() function (fwd) On Wed, Apr 05, 2023 at 02:13:16PM +0200, Florian Weimer wrote: > * Rich Felker: > > > Well this is disturbing. We probably need to fix gcc here (and a lot > > of code in the wild may be broken) because musl has no such locking > > where it doesn't belong. > > We have a helper function in glibc (_dl_find_object) that replaces all > the previous object traversal logic and caching in libgcc, so it's no > longer an issue with current gcc and glibc. Does gcc automatically detect and use this if available? What gcc versions does that cover? We could certainly add it, but I suspect coverage will be incomplete... :/ > Unfortunately that means > that the generic dl_iterate_phdr code will be fixed by adding its own > locking. Not sure why that's unfortunate; it's what it should have been doing all along. Rich