From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12269 invoked from network); 15 Apr 2023 14:16:07 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 15 Apr 2023 14:16:07 -0000 Received: (qmail 26015 invoked by uid 550); 15 Apr 2023 14:16:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 25980 invoked from network); 15 Apr 2023 14:16:03 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version; bh=16HvHGtHHWnT+CgnDVziIX9bBEY6Tpzwxmf+OwaGgr0=; b=bhvQfv7tEx/erL11mAi83T6MeTwjxDQDHBYwi+E7bWFAv8YEcnojRtVW W0JqK+ciDIrF9jRGHs8LbVPVEoeHIUPlXLKMOZLQkJ7aQ1/34QXQhkj4t WMfDyLYrWngwzzSRQerqoCrYUdNWustcQNn6B3sySZRAvdMK7WtwiBFoa 8=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=jens.gustedt@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.99,199,1677538800"; d="scan'208";a="53436972" Date: Sat, 15 Apr 2023 16:15:50 +0200 From: =?UTF-8?B?SuKCkeKCmeKCmw==?= Gustedt To: Gabriel Ravier Cc: musl@lists.openwall.com Message-ID: <20230415161550.1fb92f4e@inria.fr> In-Reply-To: References: <20220908163649.634728-1-gabravier@gmail.com> <20230415145242.6ec51d69@inria.fr> Organization: inria.fr X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/i_Kj9VUOsJSW4QHKJ5TvAEX"; protocol="application/pgp-signature"; micalg=pgp-sha1 Subject: Re: [musl] [PATCH v2 1/1] vfprintf: support C2x %b and %B conversion specifiers --Sig_/i_Kj9VUOsJSW4QHKJ5TvAEX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Gabriel, on Sat, 15 Apr 2023 15:15:48 +0200 you (Gabriel Ravier ) wrote: > > What is still missing then, is to add PRIxYYY macros. With the > > latest draft > > > > https://open-std.org/JTC1/SC22/WG14/www/docs/n3096.pdf > > > > these become mandatory feature tests for this feature. I already > > have a patch for that. =20 > Nice to have a patch for that too, thanks. I wasn't planning on > adding them myself, mostly because I don't really have any tests for > them (as opposed to the b/B conversion specifiers which I have plenty > of tests for) and don't plan on adding any anytime soon. As said they are now mandatory, because the `B` also changes state from just "recommended" to "recommended optional". The git message could also reflect that. What I noticed after sending my mail, you are also missing to do the same for vfwprintf which unfortunately doubles the logic, here. A refactoring for these two functions could probably gain some kilo or so. > > And I will soon be starting on the similar features for `scanf` and > > friends. There is one problem zone for that, namely that `0b` > > prefixes are not only extensions but change semantics of existing > > executables that would be linked against different versions of the > > C library. > > > > My plan is to make the distinction deep down in `__intscan` and have > > that internal function in two versions `__intscan_c17` and > > `__intscan_c23`, say. =20 > Doesn't the same apply to strto{,u}l{,l} given the behavior change is=20 > caused by the corresponding change in those functions ? Yes. I have a very generous notion of "friend" ;-) They all use that same function __intscan underneath, so this factors out cleanly, it seems. Thanks J=E2=82=91=E2=82=99=E2=82=9B --=20 :: ICube :::::::::::::::::::::::::::::: deputy director :: :: Universit=C3=A9 de Strasbourg :::::::::::::::::::::: ICPS :: :: INRIA Nancy Grand Est :::::::::::::::::::::::: Camus :: :: :::::::::::::::::::::::::::::::::::: =E2=98=8E +33 368854536 :: :: https://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/i_Kj9VUOsJSW4QHKJ5TvAEX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCZDqxlgAKCRAP0+hp2tU3 4pHJAJ47ANRrwhsqGeO2XWn2RIm+WcpmGACeLGjG/WPzQAHt6TlUZ+/Igin2JIU= =TTgC -----END PGP SIGNATURE----- --Sig_/i_Kj9VUOsJSW4QHKJ5TvAEX--