From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28032 invoked from network); 16 Apr 2023 06:51:31 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 16 Apr 2023 06:51:31 -0000 Received: (qmail 28509 invoked by uid 550); 16 Apr 2023 06:51:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 28475 invoked from network); 16 Apr 2023 06:51:27 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version; bh=/M3C5crD1Cqv35S5mTwyuv9RmmcsAHdi4Ym2sjYrr0w=; b=BbZENjkgtW4+IpYMXISRZp0Ax9/o37/q25Ymx/SfHokfnAmgnVpLXhB0 CwA3MnLPn7vHH1fG9g+Grd0objPjVc+Z6rBAxbXdTYtn91QQYsX8tmxyK Nw9X0POyUxcYca+QHe3c60VwHOmJVj45WhLkYQgBEEZxOW36bit2imK84 k=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=jens.gustedt@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.99,201,1677538800"; d="scan'208";a="53459262" Date: Sun, 16 Apr 2023 08:51:13 +0200 From: =?UTF-8?B?SuKCkeKCmeKCmw==?= Gustedt To: Gabriel Ravier Cc: musl@lists.openwall.com Message-ID: <20230416085113.1c88ebe5@inria.fr> In-Reply-To: References: <20220908163649.634728-1-gabravier@gmail.com> Organization: inria.fr X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/jqEGMmtF=lh=ChmvWcczRhm"; protocol="application/pgp-signature"; micalg=pgp-sha1 Subject: Re: [musl] [PATCH v2 1/1] vfprintf: support C2x %b and %B conversion specifiers --Sig_/jqEGMmtF=lh=ChmvWcczRhm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Gabriel, it also seems to me that ... on Sat, 15 Apr 2023 14:28:28 +0200 you (Gabriel Ravier ) wrote: > + /* This buffer is used for integer conversions. As such, it needs > + * to be able to contain the full representation of a number in base 2, > + * 8, 10 or 16, with base 2 having the largest possible requirement of > + * as many characters as the amount of bits in the largest > possible > + * integer type */ > + char buf[sizeof(uintmax_t)*CHAR_BIT]; ... here a `+3` seems to be in order to take care of the `0[bx]` prefix and a terminating null byte. Thanks J=E2=82=91=E2=82=99=E2=82=9B --=20 :: ICube :::::::::::::::::::::::::::::: deputy director :: :: Universit=C3=A9 de Strasbourg :::::::::::::::::::::: ICPS :: :: INRIA Nancy Grand Est :::::::::::::::::::::::: Camus :: :: :::::::::::::::::::::::::::::::::::: =E2=98=8E +33 368854536 :: :: https://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/jqEGMmtF=lh=ChmvWcczRhm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCZDua4QAKCRAP0+hp2tU3 4nsaAKCDOV0xD+wLAjvRs9rGLWCNFF8bFgCcD+RUpCeooWh0uPepwPj+CUAljzw= =o9Uk -----END PGP SIGNATURE----- --Sig_/jqEGMmtF=lh=ChmvWcczRhm--