From: Szabolcs Nagy <nsz@port70.net>
To: 847567161 <847567161@qq.com>
Cc: musl <musl@lists.openwall.com>
Subject: Re: Re: [musl] Question:Why musl call a_barrier in __pthread_once?
Date: Thu, 18 May 2023 14:23:06 +0200 [thread overview]
Message-ID: <20230518122306.GU3630668@port70.net> (raw)
In-Reply-To: <tencent_3F4518E479076E2A3E37AF6A432CEE319805@qq.com>
* 847567161 <847567161@qq.com> [2023-05-18 10:49:44 +0800]:
> > There is an alternate algorithm for pthread_once that doesn't require
> > a barrier in the common case, which I've considered implementing. But
> > it does need efficient access to thread-local storage. At one time,
> > this was a kinda bad assumption (especially legacy mips is horribly
> > slow at TLS) but nowadays it's probably the right choice to make, and
> > we should check that out again...
>
> 1、Can we move dmb after we get the value of control? like this:
>
> int __pthread_once(pthread_once_t *control, void (*init)(void))
> {
> /* Return immediately if init finished before, but ensure that
> * effects of the init routine are visible to the caller. */
> if (*(volatile int *)control == 2) {
> // a_barrier();
> return 0;
> }
writes in init may not be visible when *control==2, without
the barrier. (there are many explanations on the web why
double-checked locking is wrong without an acquire barrier,
that's the same issue if you are interested in the details)
> 2、Can we use 'ldar' to instead of dmb here? I see musl
> already use 'stlxr' in a_sc. like this:
>
> static inline int load(volatile int *p)
> {
> int v;
> __asm__ __volatile__ ("ldar %w0,%1" : "=r"(v) : "Q"(*p));
> return v;
> }
>
> if (load((volatile int *)control) == 2) {
> return 0;
> }
i think acquire ordering is enough because posix does not
require pthread_once to synchronize memory, but musl does
not have an acquire barrier/load, so it uses a_barrier.
it is probably not worth optimizing the memory order since
we know there is an algorithm that does not need a barrier
in the common case.
next prev parent reply other threads:[~2023-05-18 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 2:49 =?gb18030?B?UmU6IFJlOiBbbXVzbF0gUXVlc3Rpb26juldoeSBtdXNsIGNhbGwgYV9iYXJyaWVyIGluIF9fcHRocmVhZF9vbmNlPw==?= =?gb18030?B?ODQ3NTY3MTYx?=
2023-05-18 12:23 ` Szabolcs Nagy [this message]
2023-05-18 13:29 ` Re: [musl] Question:Why musl call a_barrier in __pthread_once? Rich Felker
2023-05-18 14:01 ` Jₑₙₛ Gustedt
2023-05-18 14:08 ` Rich Felker
2023-05-18 14:15 ` Jeffrey Walton
2023-05-18 14:20 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518122306.GU3630668@port70.net \
--to=nsz@port70.net \
--cc=847567161@qq.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).