From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21083 invoked from network); 24 May 2023 14:26:59 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 24 May 2023 14:26:59 -0000 Received: (qmail 29963 invoked by uid 550); 24 May 2023 14:26:56 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 29928 invoked from network); 24 May 2023 14:26:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version; bh=l9RVH2yNil0AYzem4uicRO1JD3eRKP6WH6QEws4AL7U=; b=I6JXbSx03pjOGzl4/i24BpbHxbHnDSPWywtcfayf1MuOYgOa1FA60BCK HNYRY26SBnyc4lrL9PnzEUcP5P1wCKchr5CvAy81JrzksM3i8+xUCMXDy 6XygauVTqOcNT+pGlyF+71qzHHoKX2QGNTUhZLABZ5tIndDQZmV/0EHhZ 0=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=jens.gustedt@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.00,189,1681164000"; d="scan'208";a="56887215" Date: Wed, 24 May 2023 16:26:43 +0200 From: =?UTF-8?B?SuKCkeKCmeKCmw==?= Gustedt To: Rich Felker Cc: musl@lists.openwall.com Message-ID: <20230524162643.584eea6e@inria.fr> In-Reply-To: <20230524142103.GV4163@brightrain.aerifal.cx> References: <20230524142103.GV4163@brightrain.aerifal.cx> Organization: inria.fr X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/I863VY872_GnQyuym6QkcC4"; protocol="application/pgp-signature"; micalg=pgp-sha1 Subject: Re: [musl] [C23 divers headers 15/17] C23: add the unreachable macro --Sig_/I863VY872_GnQyuym6QkcC4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Rich, on Wed, 24 May 2023 10:21:05 -0400 you (Rich Felker ) wrote: > On Wed, Apr 19, 2023 at 08:38:04AM +0200, Jens Gustedt wrote: > > --- > > include/stddef.h | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/include/stddef.h b/include/stddef.h > > index f25b8639..09be5fb6 100644 > > --- a/include/stddef.h > > +++ b/include/stddef.h > > @@ -24,4 +24,6 @@ > > #define offsetof(type, member) ((size_t)( (char *)&(((type > > *)0)->member) - (char *)0 )) #endif > > =20 > > +#define unreachable() __builtin_unreachable() > > + > > #endif > > --=20 > > 2.34.1 =20 >=20 > This is a namespace violation unless protected by a C version check. That would have been my first take also. I changed these things after you (I think it was you) telling me that generally interfaces that are added in newer versions of C need not be protected for older version. I probably misunderstood something. Can you please clarify under which circumstances you want feature tests and when not? Thanks J=E2=82=91=E2=82=99=E2=82=9B --=20 :: ICube :::::::::::::::::::::::::::::: deputy director :: :: Universit=C3=A9 de Strasbourg :::::::::::::::::::::: ICPS :: :: INRIA Nancy Grand Est :::::::::::::::::::::::: Camus :: :: :::::::::::::::::::::::::::::::::::: =E2=98=8E +33 368854536 :: :: https://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/I863VY872_GnQyuym6QkcC4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCZG4epAAKCRAP0+hp2tU3 4rqfAJ9W6sT4UcNPhJE69WbR3J9ODRBLugCcDjQ3sGYdwtT9yte2z5IwF4/6M44= =EK+k -----END PGP SIGNATURE----- --Sig_/I863VY872_GnQyuym6QkcC4--