From: Rich Felker <dalias@libc.org>
To: Jens Gustedt <Jens.Gustedt@inria.fr>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [C23 new stdlib 1/4] C23: add the new interfaces free_sized and free_aligned_sized for stdlib.h
Date: Wed, 24 May 2023 17:31:34 -0400 [thread overview]
Message-ID: <20230524213133.GD4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <e540f128a8d94f3ff64d5aed8021c83cc6e5f26e.1684932892.git.Jens.Gustedt@inria.fr>
On Wed, May 24, 2023 at 09:38:51PM +0200, Jens Gustedt wrote:
> For the moment, these are just trivial wrappers that ignored their
> parameters other than the pointer.
>
> The names were not previously reserved, so they could generate naming
> conflicts with application code.
>
> The "implementation" is just a trivial wrapper around free. This could
> eventually replaced by implementations that are more efficient than
> that.
> ---
> include/stdlib.h | 2 ++
> src/malloc/free.c | 10 ++++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/include/stdlib.h b/include/stdlib.h
> index 8a873f03..7800074d 100644
> --- a/include/stdlib.h
> +++ b/include/stdlib.h
> @@ -41,6 +41,8 @@ void *malloc (size_t);
> void *calloc (size_t, size_t);
> void *realloc (void *, size_t);
> void free (void *);
> +void free_sized (void *, size_t);
> +void free_aligned_sized (void *, size_t, size_t);
> void *aligned_alloc(size_t, size_t);
>
> __noreturn void abort (void);
> diff --git a/src/malloc/free.c b/src/malloc/free.c
> index 3944f7b2..2b7438bc 100644
> --- a/src/malloc/free.c
> +++ b/src/malloc/free.c
> @@ -4,3 +4,13 @@ void free(void *p)
> {
> __libc_free(p);
> }
> +
> +void free_sized (void *p, size_t size)
> +{
> + __libc_free(p);
> +}
> +
> +void free_aligned_sized (void *p, size_t alignment, size_t size)
> +{
> + __libc_free(p);
> +}
> --
> 2.34.1
These really should be in a separate file or files calling free() not
__libc_free, since if free has been replaced, they should call that,
not the libc-internal one. (Imagine a program linked or LD_PRELOADed
with an alternate malloc implementation that's not C23-aware.)
Optionally, they could also evaluate the predicate to determine if
malloc has been replaced, and if not, do the actual check. The
alignment check is trivial and malloc-agnostic. The size check would
require adding a libc-internal way to access malloc_usable_size. But
this can all be done later if desired.
Rich
next prev parent reply other threads:[~2023-05-24 21:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 19:38 [musl] [C23 new stdlib 0/4] changes in stdlib.h Jens Gustedt
2023-05-24 19:38 ` [musl] [C23 new stdlib 1/4] C23: add the new interfaces free_sized and free_aligned_sized for stdlib.h Jens Gustedt
2023-05-24 21:31 ` Rich Felker [this message]
2023-05-25 9:38 ` Jₑₙₛ Gustedt
2023-05-25 12:57 ` Rich Felker
2023-05-24 19:38 ` [musl] [C23 new stdlib 2/4] C23: add the memalignment function Jens Gustedt
2023-05-24 21:28 ` Rich Felker
2023-05-24 22:12 ` Rich Felker
2023-05-25 9:17 ` Jₑₙₛ Gustedt
2023-05-25 9:16 ` Jₑₙₛ Gustedt
2023-05-25 9:42 ` NRK
2023-05-25 13:07 ` Rich Felker
2023-05-25 14:05 ` Jₑₙₛ Gustedt
2023-05-25 14:34 ` Rich Felker
2023-05-25 15:22 ` Jₑₙₛ Gustedt
2023-06-01 13:35 ` Alexander Monakov
2023-06-01 19:08 ` Rich Felker
2023-06-02 8:07 ` Jₑₙₛ Gustedt
2023-06-02 8:03 ` Jₑₙₛ Gustedt
2023-06-02 8:37 ` Alexander Monakov
2023-05-24 19:38 ` [musl] [C23 new stdlib 3/4] C23: implement the new strfrom[dfl] functions Jens Gustedt
2023-05-24 21:42 ` Rich Felker
2023-05-24 19:38 ` [musl] [C23 new stdlib 4/4] C23: add the new include guard to stdlib.h Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524213133.GD4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=Jens.Gustedt@inria.fr \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).