From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3458 invoked from network); 29 May 2023 19:22:11 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 29 May 2023 19:22:11 -0000 Received: (qmail 28518 invoked by uid 550); 29 May 2023 19:22:08 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 28459 invoked from network); 29 May 2023 19:22:07 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version; bh=xChMjItoMG0tVhPqwW8Wu6aH5oRV0NMpbyi7p0IJkZw=; b=WMBcF4X1Lny/Jzql9R5GUrzgRTyQrETMJTGCcKCv3C4XZHeEmDDaxtWR 3ZKShal7tGiQFxeT6R46QeqLNbUjrM00ctRBve3nLMIeJP8lx7q8hvJHa JSAWcOSVL1nWE+dOxQyrHlTEaRo9hCKRvw7kyfs53zbAQqoXZOtIpFC9b g=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=jens.gustedt@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.00,201,1681164000"; d="scan'208";a="57266800" Date: Mon, 29 May 2023 21:21:55 +0200 From: =?UTF-8?B?SuKCkeKCmeKCmw==?= Gustedt To: Rich Felker Cc: musl@lists.openwall.com Message-ID: <20230529212155.583e2ab7@inria.fr> In-Reply-To: <20230529154640.GT4163@brightrain.aerifal.cx> References: <20230526203107.GN4163@brightrain.aerifal.cx> <20230526225119.4daa2815@inria.fr> <20230526210358.GQ4163@brightrain.aerifal.cx> <20230529091413.04bc8d85@inria.fr> <20230529154640.GT4163@brightrain.aerifal.cx> Organization: inria.fr X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) X-Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAACRQTFRFERslNjAsLTE9Ok9wUk9TaUs8iWhSrYZkj42Rz6aD3sGZ MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/iDoJBmDvHiA0TOSL75BX=TF"; protocol="application/pgp-signature"; micalg=pgp-sha1 Subject: Re: [musl] [C23 printf 2/3] C23: implement the wN length specifiers for printf --Sig_/iDoJBmDvHiA0TOSL75BX=TF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Rich, on Mon, 29 May 2023 11:46:40 -0400 you (Rich Felker ) wrote: > On Mon, May 29, 2023 at 09:14:13AM +0200, J=E2=82=91=E2=82=99=E2=82=9B Gu= stedt wrote: > > Rich, > >=20 > > on Fri, 26 May 2023 17:03:58 -0400 you (Rich Felker > > ) wrote: > > =20 > > > I think you need an extra state that's "plain but not bare" that > > > duplicates only the integer transitions out of it, like the l, ll, > > > etc. prefix states do. =20 > >=20 > > Hm, the problem is that for the other prefixes the table entries > > then encode the concrete type that is to be expected. We could not > > do this here because the type depends on the requested width. So we > > would then need to "repair" that type after the loop. A `switch` to > > do that would look substantially similar to what is there, now. Do > > you think that would be better? =20 >=20 > OK I think I can communicate better with code than natural language > text, so here's a diff, completely untested, of what I had in mind. that's ... ugh ... not so prety, I think In my current version I track the desired width, if there is w specifier, and then do the adjustments after the loop. That takes indeed care of undefined character sequences. I find that much better readable, and also easier to extend (later there comes the `wf` case and the `128`, and perhaps some day `256`) J=E2=82=91=E2=82=99=E2=82=9B --=20 :: ICube :::::::::::::::::::::::::::::: deputy director :: :: Universit=C3=A9 de Strasbourg :::::::::::::::::::::: ICPS :: :: INRIA Nancy Grand Est :::::::::::::::::::::::: Camus :: :: :::::::::::::::::::::::::::::::::::: =E2=98=8E +33 368854536 :: :: https://icube-icps.unistra.fr/index.php/Jens_Gustedt :: --Sig_/iDoJBmDvHiA0TOSL75BX=TF Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSN9stI2OFN1pLljN0P0+hp2tU34gUCZHT7UwAKCRAP0+hp2tU3 4ve2AJ9B52HPAHKOerm3tAY4ms6wOf+88ACgj7mZHt6V0lW4dUz5cRNtEF2gvWw= =l4tk -----END PGP SIGNATURE----- --Sig_/iDoJBmDvHiA0TOSL75BX=TF--