Re: [musl] [PATCH 1/3] RISC-V: Optimize memset

[Rich Felker <dalias@libc.org>]

On Wed, Jun 07, 2023 at 06:07:08PM +0800, zhangfei wrote:
> From: zhangfei <zhangfei@nj.iscas.ac.cn>
> 
> This code is based on linux/arch/riscv/lib/memset.S. Removed macro definition and modified
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> to support RISCV64.
> When the amount of data in the source code is less than 16 bytes or after loop tail
> processing, byte storage is used. Here we refer to musl/src/string/memset.c, and modify it
> to fill head and tail with minimal branching.
> 
> Signed-off-by: Zhang Fei<zhangfei@nj.iscas.ac.cn>
> ---
>  src/string/riscv64/memset.S | 136 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 136 insertions(+)
>  create mode 100644 src/string/riscv64/memset.S
> 
> diff --git a/src/string/riscv64/memset.S b/src/string/riscv64/memset.S
> new file mode 100644
> index 0000000..f8663d7
> --- /dev/null
> +++ b/src/string/riscv64/memset.S
> @@ -0,0 +1,136 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
                               ^^^^^^^^^^^^

This completely precludes any consideration for inclusion. Please do
not send license-incompatible code to the mailing list. Not only can
we not use it, but putting it in front of people actually working on
code suitable for musl makes us work extra hard to avoid taint.

You're free to link it into your own products (assuming you're
honoring your obligations under the GPL...), and doing so will get you
pretty much the entire benefit of having had this in libc.

Rich