From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18196 invoked from network); 21 Jun 2023 15:04:30 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 21 Jun 2023 15:04:30 -0000 Received: (qmail 21560 invoked by uid 550); 21 Jun 2023 15:04:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 21522 invoked from network); 21 Jun 2023 15:04:26 -0000 Date: Wed, 21 Jun 2023 11:04:14 -0400 From: Rich Felker To: Yonggang Luo Cc: Jens Gustedt , enh , musl@lists.openwall.com Message-ID: <20230621150412.GL4163@brightrain.aerifal.cx> References: <20230620143703.1415-1-luoyonggang@gmail.com> <20230620143703.1415-4-luoyonggang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230620143703.1415-4-luoyonggang@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] [PATCH v3 3/5] add pthread_mutex_clocklock and pthread_cond_clockdwait On Tue, Jun 20, 2023 at 10:37:01PM +0800, Yonggang Luo wrote: > These two functions are already implemented in glibc, android bionic libc, qnx libc > > Signed-off-by: Yonggang Luo > --- > compat/time32/pthread_cond_clockwait_time32.c | 9 +++++++++ > compat/time32/pthread_mutex_clocklock_time32.c | 9 +++++++++ > compat/time32/time32.h | 2 ++ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... > --- a/include/pthread.h > +++ b/include/pthread.h > [...] > > #if _REDIR_TIME64 > +__REDIR(pthread_mutex_clocklock, __pthread_mutex_clocklock_time64); > __REDIR(pthread_mutex_timedlock, __pthread_mutex_timedlock_time64); > +__REDIR(pthread_cond_clockwait, __pthread_cond_clockwait_time64); None of this is needed. There only exist redirections and legacy time32 functions for symbols which existed in the ABI with 32-bit time_t. Any newly added functions are time64 from day one. Rich