From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24959 invoked from network); 28 Jun 2023 19:28:55 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 28 Jun 2023 19:28:55 -0000 Received: (qmail 13668 invoked by uid 550); 28 Jun 2023 19:28:48 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 13602 invoked from network); 28 Jun 2023 19:28:47 -0000 Date: Wed, 28 Jun 2023 15:28:36 -0400 From: Rich Felker To: Paul Eggert Cc: linux-man@vger.kernel.org, musl@lists.openwall.com, libc-alpha@sourceware.org, libc-coord@lists.openwall.com Message-ID: <20230628192836.GV4163@brightrain.aerifal.cx> References: <20230628175329.GA16113@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] Re: regression in man pages for interfaces using loff_t On Wed, Jun 28, 2023 at 11:21:39AM -0700, Paul Eggert wrote: > On 2023-06-28 10:53, Rich Felker wrote: > >The whole reason loff_t exists is to avoid this problem and make a > >type that's "always full width offset, regardless of _FILE_OFFSET_BITS > >or _LARGEFILE64_SOURCE" to match with the kernel expectation for these > >interfaces. > > Why can't off64_t be that type, as it is in glibc? I'm not seeing > why we need two names for the same type. And to clarify one thing: nothing glibc is doing is wrong. It's fine for glibc to define the function using off64_t as long as glibc's underlying definitions of off64_t and loff_t are the same type. This still matches the published documentation that says loff_t. I'm not asking for any change by glibc here, just a revert to the man page change which put a glibc implementation-detail in place of the equivalent prior-documented public interface. Rich