mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Joakim Sindholt <>
Subject: Re: [musl] [PATCH] Add a safe dequeue integrity check for mallocng
Date: Thu, 14 Sep 2023 11:23:08 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 14 Sep 2023 13:13:23 +0800, James R T <> wrote:
> On Sat, Sep 9, 2023 at 8:48 AM Rich Felker <> wrote:
> >
> > This could and should be written with the assert macro, like all the
> > other safety assertions in mallocng, not pulling in stdio and abort.
> Understood. I was not able to find an assert with `predict_false` for
> the condition. Should I add one assert function with `predict_false`
> in `include/assert.h` or `src/exit/assert.c` or simply use the regular
> assert?

It's a little confusing but assert() in mallocng is not real assert():
The issue is that if memory is under control of an attacker then doing
anything at all, especially running the stdio machinery, is unsafe. To
that end musl uses a_crash() here which expands to a minimal set of
instructions to crash the process:

Furthermore, musl doesn't use any of thosed tagged branch tricks and I
personally doubt it would make any difference.

  reply	other threads:[~2023-09-14  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 17:49 James Raphael Tiovalen
2023-09-09  0:48 ` Rich Felker
2023-09-14  5:13   ` James R T
2023-09-14  9:23     ` Joakim Sindholt [this message]
2023-09-14 12:18       ` Rich Felker
2023-09-16  6:53         ` James R T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).