From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13259 invoked from network); 16 Nov 2023 16:11:05 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 16 Nov 2023 16:11:05 -0000 Received: (qmail 19595 invoked by uid 550); 16 Nov 2023 16:11:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19551 invoked from network); 16 Nov 2023 16:10:59 -0000 Date: Thu, 16 Nov 2023 11:10:57 -0500 From: Rich Felker To: Hongliang Wang Cc: musl@lists.openwall.com Message-ID: <20231116161056.GZ4163@brightrain.aerifal.cx> References: <20230805154307.GS4163@brightrain.aerifal.cx> <20230813014109.GU4163@brightrain.aerifal.cx> <99d954ca-faee-2cac-97af-7fc2ecdb9a89@loongson.cn> <65857ef7-0ef8-d3c8-d6d8-ea577b99e793@loongson.cn> <20230920131619.GA1427497@port70.net> <9dd23cf9-9795-0704-3a83-085ad9e6054a@loongson.cn> <3838b2d6-8330-33b5-fd87-8af3404a29dc@loongson.cn> <1f1d2528-ae86-46ea-64b1-c5b3ddb1709b@loongson.cn> <7b59ddc0-67ab-4ffa-e083-3e5086dd5de3@loongson.cn> <7aad7a07-9762-3d62-a8c2-4cdf860a7dcb@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7aad7a07-9762-3d62-a8c2-4cdf860a7dcb@loongson.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [musl] add loongarch64 port v9. On Thu, Nov 16, 2023 at 10:54:44AM +0800, Hongliang Wang wrote: > Hi, > > Thank you for your suggestion, I have modified the dynamic linker > name according to the basic ABI types are specified in the ABI > document of the LoongArch, and post 0001-add-loongarch64-port-v9.patch, > as shown in the attachment. > > Based on 0001-add-loongarch64-port-v8.patch,the modifications for > 0001-add-loongarch64-port-v9.patch are as follows: > > --- > arch/loongarch64/reloc.h | 10 ++++++---- > configure | 4 +++- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/arch/loongarch64/reloc.h b/arch/loongarch64/reloc.h > index a4482b48..6907de8e 100644 > --- a/arch/loongarch64/reloc.h > +++ b/arch/loongarch64/reloc.h > @@ -1,7 +1,9 @@ > -#ifdef __loongarch_soft_float > -#define FP_SUFFIX "-sf" > -#else > -#define FP_SUFFIX "" > +#if defined __loongarch_double_float > +#define FP_SUFFIX "-lp64d" > +#elif defined __loongarch_single_float > +#define FP_SUFFIX "-lp64f" > +#elif defined __loongarch_soft_float > +#define FP_SUFFIX "-lp64s" > #endif > > #define LDSO_ARCH "loongarch64" FP_SUFFIX > diff --git a/configure b/configure > index 55d179f1..93b06287 100755 > --- a/configure > +++ b/configure > @@ -673,7 +673,9 @@ trycppif __AARCH64EB__ "$t" && SUBARCH=${SUBARCH}_be > fi > > if test "$ARCH" = "loongarch64" ; then > -trycppif __loongarch_soft_float "$t" && SUBARCH=${SUBARCH}-sf > +trycppif __loongarch_double_float "$t" && SUBARCH=${SUBARCH}-lp64d > +trycppif __loongarch_single_float "$t" && SUBARCH=${SUBARCH}-lp64f > +trycppif __loongarch_soft_float "$t" && SUBARCH=${SUBARCH}-lp64s > printf "checking whether compiler support FCSRs... " > echo "__asm__(\"movfcsr2gr \$t0,\$fcsr0\");" > "$tmpc" > if $CC -c -o /dev/null "$tmpc" >/dev/null 2>&1 ; then > -- > > Please review again, and point them out if any questions need to be > modified, thanks. Why are you changing the ABI name for the existing one to something different rather than just adding the missing ones, and doing it with a name that's less descriptive ("-sf" is widely recognized as a softfloat suffix, -lp64s not so much) and adding a redundant "lp64" part to each one that does not seem to be part of distinguishing the float ABI? Rich