mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Gaël PORTAY" <>
Subject: [musl] [PATCH 3/3] use new SYS_fchmodat2 syscall to implement fchmodat with flags
Date: Thu, 18 Jan 2024 01:05:40 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

commit 0dc4824479e357a3e23a02d35527e23fca920343 worked around for lack
of flags argument in syscall for fchmodat.

linux 6.6 introduced a new syscall, SYS_fchmodat2, fixing this
deficiency. use it if any flags are passed, and fallback to the old
strategy on ENOSYS. continue using the old syscall when there are no
flags. this is the exact same strategy used when SYS_faccessat2 was used
to implement faccessat with flags.
 src/stat/fchmodat.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/stat/fchmodat.c b/src/stat/fchmodat.c
index 41db0c46..a3f407e3 100644
--- a/src/stat/fchmodat.c
+++ b/src/stat/fchmodat.c
@@ -5,6 +5,11 @@
 int fchmodat(int fd, const char *path, mode_t mode, int flag)
+	if (flag) {
+		int ret = __syscall(SYS_fchmodat2, fd, path, mode, flag);
+		if (ret != -ENOSYS) return __syscall_ret(ret);
+	}
 	if (!flag) return syscall(SYS_fchmodat, fd, path, mode);
 	if (flag != AT_SYMLINK_NOFOLLOW)

      parent reply	other threads:[~2024-01-18  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18  0:05 [musl] [PATCH 0/3] " Gaël PORTAY
2024-01-18  0:05 ` [musl] [PATCH 1/3] remove flag argument from fchmodat syscall Gaël PORTAY
2024-01-18  0:05 ` [musl] [PATCH 2/3] bits/syscall.h: add __NR_fchmodat2 from linux v6.6 Gaël PORTAY
2024-02-08  2:10   ` Rich Felker
2024-01-18  0:05 ` Gaël PORTAY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).